Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1767)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1312843012: Use DCHECK_CURRENTLY_ON in content/ (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mkwst+moarreviews-renderer_chromium.org, posciak+watch_chromium.org, wfh+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, tracing+reviews_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use DCHECK_CURRENTLY_ON in content/ Committed: https://crrev.com/475bf9108b0127ed5cb78a781991b120012a41b6 Cr-Commit-Position: refs/heads/master@{#347835}

Patch Set 1 #

Total comments: 2

Patch Set 2 : revert bad search/replace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/tracing_controller_impl_data_sinks.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/browser_render_view_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Lei Zhang
5 years, 3 months ago (2015-09-08 18:43:00 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 3 months ago (2015-09-08 19:22:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312843012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312843012/1
5 years, 3 months ago (2015-09-08 19:25:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/66218)
5 years, 3 months ago (2015-09-08 21:05:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312843012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312843012/1
5 years, 3 months ago (2015-09-08 21:06:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/66278)
5 years, 3 months ago (2015-09-08 22:47:45 UTC) #11
Lei Zhang
https://codereview.chromium.org/1312843012/diff/1/content/browser/android/child_process_launcher_android.cc File content/browser/android/child_process_launcher_android.cc (left): https://codereview.chromium.org/1312843012/diff/1/content/browser/android/child_process_launcher_android.cc#oldcode183 content/browser/android/child_process_launcher_android.cc:183: DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::UI)); gah, search and replace fail.
5 years, 3 months ago (2015-09-08 22:50:22 UTC) #12
Lei Zhang
https://codereview.chromium.org/1312843012/diff/1/content/browser/android/child_process_launcher_android.cc File content/browser/android/child_process_launcher_android.cc (left): https://codereview.chromium.org/1312843012/diff/1/content/browser/android/child_process_launcher_android.cc#oldcode183 content/browser/android/child_process_launcher_android.cc:183: DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::UI)); On 2015/09/08 22:50:22, Lei Zhang wrote: > gah, ...
5 years, 3 months ago (2015-09-08 22:59:43 UTC) #13
Lei Zhang
5 years, 3 months ago (2015-09-08 22:59:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312843012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312843012/20001
5 years, 3 months ago (2015-09-08 23:00:18 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-08 23:50:32 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 23:51:46 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/475bf9108b0127ed5cb78a781991b120012a41b6
Cr-Commit-Position: refs/heads/master@{#347835}

Powered by Google App Engine
This is Rietveld 408576698