Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1312843008: Remove CSSParserMode argument on CSSParser::parseValue (Closed)

Created:
5 years, 3 months ago by Timothy Loh
Modified:
5 years, 3 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, Rik, dglazkov+blink, dshwang, Justin Novosad, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove CSSParserMode argument on CSSParser::parseValue The StylePropertySet passed in to CSSParser::parseValue already has a parse mode associated with it, which we can use instead of passing a separate parser mode argument. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201543

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M Source/core/css/DOMWindowCSS.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/FontFaceSet.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/StylePropertySet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParser.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasFontCache.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
5 years, 3 months ago (2015-09-01 07:43:51 UTC) #2
alancutter (OOO until 2018)
lgtm
5 years, 3 months ago (2015-09-01 07:45:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312843008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312843008/1
5 years, 3 months ago (2015-09-01 09:26:58 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 09:31:36 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201543

Powered by Google App Engine
This is Rietveld 408576698