Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: runtime/vm/symbols.cc

Issue 1312833009: Added {Zone}GrowableHandlePtrArray types: simplifies code, makes code safer (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: d Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/symbols.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/symbols.cc
diff --git a/runtime/vm/symbols.cc b/runtime/vm/symbols.cc
index 2078a21c7a4b3b4772e845f085f4b75e17182138..be081818ba689bfeff188d4dc054f38f1e4668c5 100644
--- a/runtime/vm/symbols.cc
+++ b/runtime/vm/symbols.cc
@@ -395,12 +395,13 @@ RawString* Symbols::FromConcat(const String& str1, const String& str2) {
// TODO(srdjan): If this becomes performance critical code, consider looking
// up symbol from pieces instead of concatenating them first into a big string.
-RawString* Symbols::FromConcatAll(const GrowableArray<const String*>& strs) {
+RawString* Symbols::FromConcatAll(
+ const GrowableHandlePtrArray<const String>& strs) {
GrowableArray<const char*> cchars(strs.length());
GrowableArray<intptr_t> lengths(strs.length());
intptr_t len_sum = 0;
for (intptr_t i = 0; i < strs.length(); i++) {
- const char* to_cstr = strs[i]->ToCString();
+ const char* to_cstr = strs[i].ToCString();
intptr_t len = strlen(to_cstr);
cchars.Add(to_cstr);
lengths.Add(len);
« no previous file with comments | « runtime/vm/symbols.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698