Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: runtime/vm/growable_array_test.cc

Issue 1312833009: Added {Zone}GrowableHandlePtrArray types: simplifies code, makes code safer (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/growable_array_test.cc
diff --git a/runtime/vm/growable_array_test.cc b/runtime/vm/growable_array_test.cc
index 09c16050af58a8c018206f239acb18a218f0ca1d..fedb9c85beac7f27f31e7641c765ad0ffc621f38 100644
--- a/runtime/vm/growable_array_test.cc
+++ b/runtime/vm/growable_array_test.cc
@@ -96,4 +96,20 @@ TEST_CASE(GrowableArraySort) {
EXPECT_EQ(4, g.Last());
}
+
+TEST_CASE(GrowableHandlePtr) {
+ Zone* zone = Thread::Current()->zone();
+ GrowableHandlePtrArray<const String> test1(zone, 1);
+ EXPECT_EQ(0, test1.length());
+ test1.Add(Symbols::Int());
+ EXPECT(test1[0].raw() == Symbols::Int().raw());
+ EXPECT_EQ(1, test1.length());
+
+ ZoneGrowableHandlePtrArray<const String>* test2 =
+ new ZoneGrowableHandlePtrArray<const String>(zone, 1);
+ test2->Add(Symbols::GetterPrefix());
+ EXPECT((*test2)[0].raw() == Symbols::GetterPrefix().raw());
+ EXPECT_EQ(1, test2->length());
+}
+
} // namespace dart

Powered by Google App Engine
This is Rietveld 408576698