Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1312833007: Revert of Reland [Startup Tracing] Add --trace-config-file flag (Closed)

Created:
5 years, 3 months ago by sergeyv
Modified:
5 years, 3 months ago
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, wfh+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, penghuang+watch-mandoline_chromium.org, tracing+reviews_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland [Startup Tracing] Add --trace-config-file flag (patchset #2 id:20001 of https://codereview.chromium.org/1317333002/ ) Reason for revert: Broke build at Win x64 GN. Failure sample: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/8575 Original issue's description: > Reland [Startup Tracing] Add --trace-config-file flag > > Original CL: https://codereview.chromium.org/1315463002/ > > This CL adds --trace-config-file flag. Please see trace_config_file.h for details. > > Design doc: > https://docs.google.com/document/d/1PgdXUOJF3WtEmYWUyGRbC2Fz2ICCZKO9jPvpLPRSHH8/edit?usp=sharing > > BUG=317481, 482098 > TBR=dsinclair@chromium.org,blundell@chromium.org,sievers@chromium.org,sky@chromium.org,msw@chromium.org > > Committed: https://crrev.com/a556ab616a3817468a9bd2163383dafe24ffdc96 > Cr-Commit-Position: refs/heads/master@{#346189} TBR=dsinclair@chromium.org,blundell@chromium.org,sievers@chromium.org,msw@chromium.org,sky@chromium.org,zhenw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=317481, 482098 Committed: https://crrev.com/1eab556bee2e0ff9c2d2cec7983253d52bc998d9 Cr-Commit-Position: refs/heads/master@{#346206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -584 lines) Patch
M components/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 3 chunks +0 lines, -5 lines 0 comments Download
M components/tracing.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M components/tracing/BUILD.gn View 2 chunks +2 lines, -16 lines 0 comments Download
A components/tracing/startup_tracing.h View 1 chunk +20 lines, -0 lines 0 comments Download
A components/tracing/startup_tracing.cc View 1 chunk +66 lines, -0 lines 0 comments Download
D components/tracing/trace_config_file.h View 1 chunk +0 lines, -94 lines 0 comments Download
D components/tracing/trace_config_file.cc View 1 chunk +0 lines, -140 lines 0 comments Download
D components/tracing/trace_config_file_unittest.cc View 1 chunk +0 lines, -220 lines 0 comments Download
M components/tracing/tracing_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/tracing/tracing_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/tracing_nacl.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M content/app/android/library_loader_hooks.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M content/app/content_main_runner.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M content/browser/browser_main_loop.h View 5 chunks +5 lines, -7 lines 0 comments Download
M content/browser/browser_main_loop.cc View 5 chunks +28 lines, -44 lines 0 comments Download
M content/browser/browser_main_runner.cc View 2 chunks +1 line, -19 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/plugin_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -2 lines 0 comments Download
M mandoline/app/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/app/desktop/launcher_process.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M mojo/runner/desktop/launcher_process.cc View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sergeyv
Created Revert of Reland [Startup Tracing] Add --trace-config-file flag
5 years, 3 months ago (2015-08-28 19:09:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312833007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312833007/1
5 years, 3 months ago (2015-08-28 19:10:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 19:12:19 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 19:13:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1eab556bee2e0ff9c2d2cec7983253d52bc998d9
Cr-Commit-Position: refs/heads/master@{#346206}

Powered by Google App Engine
This is Rietveld 408576698