Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: ui/events/x/events_x.cc

Issue 1312833006: Remove ui::KeyEvent::platform_keycode_ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/win/events_win.cc ('k') | ui/platform_window/android/platform_window_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/x/events_x.cc
diff --git a/ui/events/x/events_x.cc b/ui/events/x/events_x.cc
index d9dec447e71e48a8e224a1e0ca68413d218659a3..f71fbcb9f8a5bb14c6fce9d16fef632aa1492e85 100644
--- a/ui/events/x/events_x.cc
+++ b/ui/events/x/events_x.cc
@@ -646,41 +646,6 @@ DomCode CodeFromNative(const base::NativeEvent& native_event) {
return CodeFromXEvent(native_event);
}
-uint32 PlatformKeycodeFromNative(const base::NativeEvent& native_event) {
- XKeyEvent* xkey = NULL;
- XEvent xkey_from_xi2;
- switch (native_event->type) {
- case KeyPress:
- case KeyRelease:
- xkey = &native_event->xkey;
- break;
- case GenericEvent: {
- XIDeviceEvent* xievent =
- static_cast<XIDeviceEvent*>(native_event->xcookie.data);
- switch (xievent->evtype) {
- case XI_KeyPress:
- case XI_KeyRelease:
- // Build an XKeyEvent corresponding to the XI2 event,
- // so that we can call XLookupString on it.
- InitXKeyEventFromXIDeviceEvent(*native_event, &xkey_from_xi2);
- xkey = &xkey_from_xi2.xkey;
- break;
- default:
- NOTREACHED();
- break;
- }
- break;
- }
- default:
- NOTREACHED();
- break;
- }
- KeySym keysym = XK_VoidSymbol;
- if (xkey)
- XLookupString(xkey, NULL, 0, &keysym, NULL);
- return keysym;
-}
-
bool IsCharFromNative(const base::NativeEvent& native_event) {
return false;
}
« no previous file with comments | « ui/events/win/events_win.cc ('k') | ui/platform_window/android/platform_window_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698