Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: ui/events/event.h

Issue 1312833006: Remove ui::KeyEvent::platform_keycode_ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/cocoa/events_mac.mm ('k') | ui/events/event.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/event.h
diff --git a/ui/events/event.h b/ui/events/event.h
index eff791345993767b349e0ed3d9fa211e0e4e0299..e077ed34841def81557fac74be799e10d8d751f1 100644
--- a/ui/events/event.h
+++ b/ui/events/event.h
@@ -750,11 +750,6 @@ class EVENTS_EXPORT KeyEvent : public Event {
// as GetUnmodifiedText().
base::char16 GetText() const;
- // Gets the platform key code. For XKB, this is the xksym value.
- // This should not be used in new code.
- void set_platform_keycode(uint32 keycode) { platform_keycode_ = keycode; }
- uint32 platform_keycode() const { return platform_keycode_; }
-
// Gets the associated (Windows-based) KeyboardCode for this key event.
// Historically, this has also been used to obtain the character associated
// with a character event, because both use the Window message 'wParam' field.
@@ -817,10 +812,6 @@ class EVENTS_EXPORT KeyEvent : public Event {
// True if this is a character event, false if this is a keystroke event.
bool is_char_ = false;
- // The platform related keycode value. For XKB, it's keysym value.
- // For now, this is used for CharacterComposer in ChromeOS.
- mutable uint32 platform_keycode_ = 0;
-
// TODO(kpschoedel): refactor so that key_ is not mutable.
// This requires defining the KeyEvent completely at construction rather
// than lazily under GetCharacter(), which likely also means removing
« no previous file with comments | « ui/events/cocoa/events_mac.mm ('k') | ui/events/event.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698