Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1312813007: styleguide: mention "alignof" operation under "Alignment Features" (Closed)

Created:
5 years, 3 months ago by mdempsky
Modified:
5 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews, jamesr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

styleguide: mention "alignof" operation under "Alignment Features" For completeness. Committed: https://crrev.com/b54ffc378660d7f8f68ab27608d7c71b843318f0 Cr-Commit-Position: refs/heads/master@{#349525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M styleguide/c++/c++11.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
mdempsky
FWIW, it looks like Chromium's ALIGNOF macro only uses the GCC __alignof__ and the MSVC ...
5 years, 3 months ago (2015-09-03 22:55:38 UTC) #2
mdempsky
R= +jamesr, -thakis (Sorry, didn't notice thakis's vacation notice until after mailing.)
5 years, 3 months ago (2015-09-03 22:57:28 UTC) #4
jamesr
r->thakis (I'm just about to go on vacation and don't have time to study this)
5 years, 3 months ago (2015-09-03 23:00:44 UTC) #6
mdempsky
danakj: Looks like you're the only styleguide/c++ OWNER not on vacation. This CL just adds ...
5 years, 3 months ago (2015-09-03 23:14:57 UTC) #8
danakj
LGTM
5 years, 3 months ago (2015-09-17 22:33:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312813007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312813007/1
5 years, 3 months ago (2015-09-17 22:35:26 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 22:50:47 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 22:51:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b54ffc378660d7f8f68ab27608d7c71b843318f0
Cr-Commit-Position: refs/heads/master@{#349525}

Powered by Google App Engine
This is Rietveld 408576698