Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: runtime/vm/zone.h

Issue 1312813006: - Remove deprecated StackZone constructor with Isolate parameter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/zone.h
diff --git a/runtime/vm/zone.h b/runtime/vm/zone.h
index 79591a5dfaadf46ca4e679fd9297f18960594e35..4850e5eb321d67863cd7d6b587a016148e69c911 100644
--- a/runtime/vm/zone.h
+++ b/runtime/vm/zone.h
@@ -178,13 +178,15 @@ class StackZone : public StackResource {
public:
// Create an empty zone and set is at the current zone for the Thread.
explicit StackZone(Thread* thread) : StackResource(thread), zone_() {
- Initialize();
- }
-
- // DEPRECATED: Use Thread-based interface. During migration, this defaults
- // to using the mutator thread (which must also be the current thread).
- explicit StackZone(Isolate* isolate) : StackResource(isolate), zone_() {
- Initialize();
+#ifdef DEBUG
+ if (FLAG_trace_zones) {
+ OS::PrintErr("*** Starting a new Stack zone 0x%" Px "(0x%" Px ")\n",
+ reinterpret_cast<intptr_t>(this),
+ reinterpret_cast<intptr_t>(&zone_));
+ }
+#endif
+ zone_.Link(thread->zone());
+ thread->set_zone(&zone_);
}
// Delete all memory associated with the zone.
@@ -209,18 +211,6 @@ class StackZone : public StackResource {
private:
Zone zone_;
- void Initialize() {
-#ifdef DEBUG
- if (FLAG_trace_zones) {
- OS::PrintErr("*** Starting a new Stack zone 0x%" Px "(0x%" Px ")\n",
- reinterpret_cast<intptr_t>(this),
- reinterpret_cast<intptr_t>(&zone_));
- }
-#endif
- zone_.Link(thread()->zone());
- thread()->set_zone(&zone_);
- }
-
template<typename T> friend class GrowableArray;
template<typename T> friend class ZoneGrowableArray;

Powered by Google App Engine
This is Rietveld 408576698