chrome/test/BUILD.gn - Issue 1312813003: add nacl_toolchain to //build and flip to using it in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/BUILD.gn

Issue 1312813003: add nacl_toolchain to //build and flip to using it in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@build_changes

Patch Set: rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/BUILD.gn

diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn

index 602a90c2fbac32ba2a1fdd52eb2fb2eef0f5eb4a..d2c416a41e9c4d87db40ad2eaf1e4f3ff8697ef3 100644

--- a/chrome/test/BUILD.gn

+++ b/chrome/test/BUILD.gn

@@ -782,7 +782,7 @@ if (!is_android) {

assert(current_cpu == "x64")

data_deps += [

# "test/data/nacl:shared_test_files", # TODO(GYP) bug 512902

- "//ppapi/native_client:nacl_irt(//native_client/build/toolchain/nacl:irt_x64)",

+ "//ppapi/native_client:nacl_irt(//build/toolchain/nacl:irt_x64)",

# "../ppapi/ppapi_nacl.gyp:ppapi_nacl_tests", # TODO(GYP) bug 512901

# "../ppapi/tests/extensions/extensions.gyp:ppapi_tests_extensions_background_keepalive", # TODO(GYP) bug 512900

# "../ppapi/tests/extensions/extensions.gyp:ppapi_tests_extensions_media_galleries", # TODO(GYP) bug 512900

« build/toolchain/nacl_toolchain.gni ('K') | « build/toolchain/nacl_toolchain.gni ('k') | components/nacl/BUILD.gn » ('j') | third_party/mojo/src/nacl_bindings/BUILD.gn » ('J')