Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: runtime/vm/service/service.md

Issue 1312763010: Support column-based breakpoints in the VM and Observatory. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/object.cc ('K') | « runtime/vm/service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service/service.md
diff --git a/runtime/vm/service/service.md b/runtime/vm/service/service.md
index c18f390d9bc59962a9686c5b0dea7e7e7e99e268..eff368c114ebc42e60258fa500cccda0a5b0f86a 100644
--- a/runtime/vm/service/service.md
+++ b/runtime/vm/service/service.md
@@ -371,13 +371,29 @@ in the section on [public types](#public-types).
```
Breakpoint addBreakpoint(string isolateId,
- string scriptId,
- int line)
+ string scriptId [optional],
+ string scriptUrl [optional],
+ int line,
+ int column)
rmacnak 2015/09/03 00:55:19 int column [optional]
turnidge 2015/09/04 18:05:29 Done.
```
The _addBreakpoint_ RPC is used to add a breakpoint at a specific line
of some script.
+The _scriptId_ or _scriptUrl_ parameter is used to specify the target
+script. One of these two parameters must always be provided.
+
+The _line_ parameter is used to specify the target line for the
+breakpoint. If there are multiple possible breakpoints on the target
+line, then the VM will place the breakpoint at the location which
+would execute soonest. If it is not possible to set a breakpoint at
+the target line, the breakpoint will be added at the next possible
+breakpoint location within the same function.
+
+The _column_ parameter may be optionally specified. This is useful
+for targeting a specific breakpoint on a line with multiple possible
+breakpoints.
+
If no breakpoint is possible at that line, the _102_ (Cannot add
breakpoint) error code is returned.
« runtime/vm/object.cc ('K') | « runtime/vm/service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698