Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1312763004: Rationalize the top-level BUILD.gn rules a bit (Closed)

Created:
5 years, 4 months ago by jamesr
Modified:
5 years, 4 months ago
Reviewers:
viettrungluu
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rationalize the top-level BUILD.gn rules a bit Historically for reasons that are no longer relevant //mojo/BUILD.gn's "mojo" target has been treated as the global metatarget to add new things to, including targets in other top-level directories like //services. This rationalizes the dependency structure in the top few build files to more closely match the directory structure. //BUILD.gn references metatargets in top level directories and //{services,mojo,shell}/BUILD.gn handle references within those //directories. This will hopefully make it clearer where to add new //targets. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/25dfab20ede060a13acea2adc34164ab0feb17b1

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -42 lines) Patch
M BUILD.gn View 3 chunks +11 lines, -1 line 0 comments Download
M mojo/BUILD.gn View 4 chunks +1 line, -40 lines 0 comments Download
M services/BUILD.gn View 2 chunks +42 lines, -1 line 2 comments Download
M shell/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jamesr
5 years, 4 months ago (2015-08-24 18:05:45 UTC) #2
viettrungluu
lgtm w/nit https://codereview.chromium.org/1312763004/diff/1/services/BUILD.gn File services/BUILD.gn (right): https://codereview.chromium.org/1312763004/diff/1/services/BUILD.gn#newcode81 services/BUILD.gn:81: if (is_linux) { nit: blank line above? ...
5 years, 4 months ago (2015-08-24 21:55:29 UTC) #3
jamesr
https://codereview.chromium.org/1312763004/diff/1/services/BUILD.gn File services/BUILD.gn (right): https://codereview.chromium.org/1312763004/diff/1/services/BUILD.gn#newcode81 services/BUILD.gn:81: if (is_linux) { On 2015/08/24 at 21:55:29, viettrungluu wrote: ...
5 years, 4 months ago (2015-08-24 21:58:11 UTC) #4
jamesr
5 years, 4 months ago (2015-08-24 22:20:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
25dfab20ede060a13acea2adc34164ab0feb17b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698