Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1312753004: Add support for keyboard commands on iOS. (Closed)

Created:
5 years, 3 months ago by lpromero
Modified:
5 years, 3 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for keyboard commands on iOS. This CL adds the core for handling keyboard commands on iOS. BUG=437260 Committed: https://crrev.com/9abb76be2b2ef9a7b4eadb0e7213cbc173d1faff Cr-Commit-Position: refs/heads/master@{#347157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -4 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +16 lines, -1 line 0 comments Download
M ios/chrome/browser/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/chrome_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/experimental_flags.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/commands/generic_chrome_command.h View 2 chunks +6 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/commands/generic_chrome_command.mm View 1 chunk +4 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/keyboard/UIKeyCommand+Chrome.h View 1 chunk +93 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/keyboard/UIKeyCommand+Chrome.mm View 1 chunk +92 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/keyboard/UIKeyCommand+ChromeTest.mm View 1 chunk +27 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
lpromero
5 years, 3 months ago (2015-09-03 13:59:40 UTC) #1
lpromero
5 years, 3 months ago (2015-09-03 14:19:09 UTC) #3
sdefresne
rubber stamp lgtm (original review happened downstream)
5 years, 3 months ago (2015-09-03 14:28:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312753004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312753004/1
5 years, 3 months ago (2015-09-03 15:04:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 15:10:10 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 15:11:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9abb76be2b2ef9a7b4eadb0e7213cbc173d1faff
Cr-Commit-Position: refs/heads/master@{#347157}

Powered by Google App Engine
This is Rietveld 408576698