Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1312713005: [Line Layout API] Add rubyBase to LineLayoutRubyRun (Closed)

Created:
5 years, 3 months ago by pilgrim_google
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Line Layout API] Add rubyBase to LineLayoutRubyRun This CL updates all callers in InlineFlowBox. BUG=499321 Committed: https://crrev.com/a9a55e9cc9fb34e764df1bde56018afce7d3d4bb git-svn-id: svn://svn.chromium.org/blink/trunk@201991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M Source/core/layout/api/LineLayoutRubyRun.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/layout/line/InlineFlowBox.cpp View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pilgrim_google
5 years, 3 months ago (2015-09-03 17:19:36 UTC) #2
pilgrim_google
bump
5 years, 3 months ago (2015-09-08 13:32:22 UTC) #3
eae
LGTM
5 years, 3 months ago (2015-09-09 16:57:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312713005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312713005/20001
5 years, 3 months ago (2015-09-09 17:08:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201991
5 years, 3 months ago (2015-09-09 18:50:46 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:01:37 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a9a55e9cc9fb34e764df1bde56018afce7d3d4bb

Powered by Google App Engine
This is Rietveld 408576698