Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: src/x87/lithium-codegen-x87.cc

Issue 1312713004: Remove CompilationInfo::MayUseThis() and replace it with what we really want to know: MustReplaceUn… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 #ifdef DEBUG 102 #ifdef DEBUG
103 if (strlen(FLAG_stop_at) > 0 && 103 if (strlen(FLAG_stop_at) > 0 &&
104 info_->literal()->name()->IsUtf8EqualTo(CStrVector(FLAG_stop_at))) { 104 info_->literal()->name()->IsUtf8EqualTo(CStrVector(FLAG_stop_at))) {
105 __ int3(); 105 __ int3();
106 } 106 }
107 #endif 107 #endif
108 108
109 // Sloppy mode functions and builtins need to replace the receiver with the 109 // Sloppy mode functions and builtins need to replace the receiver with the
110 // global proxy when called as functions (without an explicit receiver 110 // global proxy when called as functions (without an explicit receiver
111 // object). 111 // object).
112 if (is_sloppy(info()->language_mode()) && info()->MayUseThis() && 112 if (info()->MustReplaceUndefinedReceiverWithGlobalProxy()) {
113 !info()->is_native() && info()->scope()->has_this_declaration()) {
114 Label ok; 113 Label ok;
115 // +1 for return address. 114 // +1 for return address.
116 int receiver_offset = (scope()->num_parameters() + 1) * kPointerSize; 115 int receiver_offset = (scope()->num_parameters() + 1) * kPointerSize;
117 __ mov(ecx, Operand(esp, receiver_offset)); 116 __ mov(ecx, Operand(esp, receiver_offset));
118 117
119 __ cmp(ecx, isolate()->factory()->undefined_value()); 118 __ cmp(ecx, isolate()->factory()->undefined_value());
120 __ j(not_equal, &ok, Label::kNear); 119 __ j(not_equal, &ok, Label::kNear);
121 120
122 __ mov(ecx, GlobalObjectOperand()); 121 __ mov(ecx, GlobalObjectOperand());
123 __ mov(ecx, FieldOperand(ecx, GlobalObject::kGlobalProxyOffset)); 122 __ mov(ecx, FieldOperand(ecx, GlobalObject::kGlobalProxyOffset));
(...skipping 6239 matching lines...) Expand 10 before | Expand all | Expand 10 after
6363 RecordSafepoint(Safepoint::kNoLazyDeopt); 6362 RecordSafepoint(Safepoint::kNoLazyDeopt);
6364 } 6363 }
6365 6364
6366 6365
6367 #undef __ 6366 #undef __
6368 6367
6369 } // namespace internal 6368 } // namespace internal
6370 } // namespace v8 6369 } // namespace v8
6371 6370
6372 #endif // V8_TARGET_ARCH_X87 6371 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698