Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1312703004: Add empty files to empty targets to appease XCode. (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add empty files to empty targets to appease XCode. BUG=skia:4117 Committed: https://skia.googlesource.com/skia/+/46b42f5304e883f6337b4fd435b3dcd63ade3612

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M gyp/opts.gypi View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312703004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312703004/1
5 years, 3 months ago (2015-08-31 18:52:42 UTC) #2
mtklein_C
5 years, 3 months ago (2015-08-31 18:55:51 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-31 18:58:03 UTC) #6
reed1
Fixed my issue, thanks! lgtm PS -- lets ask Eric to have a build explicitly ...
5 years, 3 months ago (2015-08-31 21:19:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312703004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312703004/1
5 years, 3 months ago (2015-08-31 21:20:24 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 21:21:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/46b42f5304e883f6337b4fd435b3dcd63ade3612

Powered by Google App Engine
This is Rietveld 408576698