Chromium Code Reviews

Issue 1312703003: [simd.js] Set --harmony-simd flag in test config. (Closed)

Created:
5 years, 4 months ago by bbudge
Modified:
5 years, 4 months ago
Reviewers:
Dan Ehrenberg, dehrenberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[simd.js] Set --harmony-simd flag in test config. Adds the flag to the test configuration so we aren't just testing the polyfill. Fixes some number conversion in native fromFloat32x4 function that now fails. LOG=N BUG=v8:4124 Committed: https://crrev.com/2090c08d3ebafbabf5e2a85a58d605d60cbf6650 Cr-Commit-Position: refs/heads/master@{#30341}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+20 lines, -12 lines)
M src/runtime/runtime-simd.cc View 3 chunks +19 lines, -11 lines 0 comments
M test/simdjs/testcfg.py View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 8 (3 generated)
bbudge
5 years, 4 months ago (2015-08-24 20:57:32 UTC) #2
Dan Ehrenberg
lgtm Yay for testing!
5 years, 4 months ago (2015-08-24 21:01:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312703003/1
5 years, 4 months ago (2015-08-24 21:08:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-24 21:18:59 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 21:19:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2090c08d3ebafbabf5e2a85a58d605d60cbf6650
Cr-Commit-Position: refs/heads/master@{#30341}

Powered by Google App Engine