Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Unified Diff: src/jump-target-ia32.cc

Issue 13127: Initial real implementation of simple merge for frames. Does not yet... (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/toiger/
Patch Set: '' Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/flag-definitions.h ('k') | src/register-allocator-ia32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/jump-target-ia32.cc
===================================================================
--- src/jump-target-ia32.cc (revision 894)
+++ src/jump-target-ia32.cc (working copy)
@@ -69,11 +69,13 @@
if (expected_frame_ == NULL) {
expected_frame_ = current_frame;
- expected_frame_->EnsureMergable();
// The frame at the actual function return will always have height zero.
if (code_generator_->IsActualFunctionReturn(this)) {
expected_frame_->Forget(expected_frame_->height());
}
+ if (!expected_frame_->IsMergable()) {
+ expected_frame_->MakeMergable();
+ }
code_generator_->set_frame(NULL);
} else {
// No code needs to be emitted to merge to the expected frame at the
@@ -101,11 +103,13 @@
if (expected_frame_ == NULL) {
expected_frame_ = new VirtualFrame(current_frame);
- expected_frame_->EnsureMergable();
// The frame at the actual function return will always have height zero.
if (code_generator_->IsActualFunctionReturn(this)) {
expected_frame_->Forget(expected_frame_->height());
}
+ if (!expected_frame_->IsMergable()) {
+ expected_frame_->MakeMergable();
+ }
} else {
// No code needs to be emitted to merge to the expected frame at the
// actual function return.
@@ -132,7 +136,9 @@
ASSERT(expected_frame_ == NULL);
expected_frame_ = new VirtualFrame(current_frame);
- expected_frame_->EnsureMergable();
+ if (!expected_frame_->IsMergable()) {
+ expected_frame_->MakeMergable();
+ }
// Adjust the expected frame's height to account for the return address
// pushed by the call instruction.
expected_frame_->Adjust(1);
@@ -156,11 +162,13 @@
if (expected_frame_ == NULL) {
expected_frame_ = new VirtualFrame(current_frame);
- expected_frame_->EnsureMergable();
// The frame at the actual function return will always have height zero.
if (code_generator_->IsActualFunctionReturn(this)) {
expected_frame_->Forget(expected_frame_->height());
}
+ if (!expected_frame_->IsMergable()) {
+ expected_frame_->MakeMergable();
+ }
} else if (current_frame == NULL) {
code_generator_->set_frame(new VirtualFrame(expected_frame_));
} else {
« no previous file with comments | « src/flag-definitions.h ('k') | src/register-allocator-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698