chrome/browser/ui/startup/startup_browser_creator_impl.cc - Issue 1312693005: Remove migration of obsolete value for "session.restore_on_startup".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 1312693005: Remove migration of obsolete value for "session.restore_on_startup". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@url-to-restore-on-startup

Patch Set: Address comments by bartfab & rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/prefs/session_startup_pref.cc ('K') | « chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc ('k') | chrome/common/pref_names.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

index ecbc5dc81b1829f603ecab69608efbbcdea3efe3..381a078f02e8aa14c4899efbd34ee2b280dd62a5 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

@@ -684,10 +684,6 @@ Browser* StartupBrowserCreatorImpl::ProcessSpecifiedURLs(

// specified on the command line. Filter out any urls that are to be

// restored by virtue of having been previously pinned.

AddUniqueURLs(pref.urls, &tabs);

- } else if (pref.type == SessionStartupPref::HOMEPAGE) {

- // If 'homepage' selected, either by the user or by a policy, we should

- // have migrated them to another value.

- NOTREACHED() << "SessionStartupPref has deprecated type HOMEPAGE";

}

if (tabs.empty())