Remove migration of obsolete value for "session.restore_on_startup".

Remove migration of obsolete value for "session.restore_on_startup".

Remove support of migration of kPrefValueHomePage (0) for the preference
"session.restore_on_startup" that was obsolete when M-19 was released.

Remove all usage of the constant kPrefValueHomePage and of the preference
"session.restore_on_startup_migrated" tracking whether the migration had
happened.

BUG=525079
Committed: https://crrev.com/245bbd424846eb696fea8b35718df3b7e9892c9f
Cr-Commit-Position: refs/heads/master@{#364142}

[sdefresne, 2015-08-26 16:17:16]

sdefresne@chromium.org changed reviewers:
+ atwilson@chromium.org, bartfab@chromium.org, gab@chromium.org

[sdefresne, 2015-08-26 16:17:16]

Please review this change.

[gab, 2015-08-27 17:52:48]

lgtm pending approval from enterprise on email thread.

Thanks!
Gab

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/policy/p...
File chrome/browser/policy/policy_browsertest.cc (left):

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/policy/p...
chrome/browser/policy/policy_browsertest.cc:3196: void HomepageIsNotNTP() {
Seems we're removing an unintentionally supported policy use case (pinged on
email thread to make sure this is okay -- no action required if they're okay
with it).

[bartfab (slow), 2015-08-31 15:36:14]

bartfab@chromium.org changed reviewers:
+ askvitkine@chromium.org

[bartfab (slow), 2015-08-31 15:36:43]

Just some nits in the code. However, as suggested by Gabriel, we need to make a
decision on the e-mail thread regarding enterprise users before we remove this
legacy code.

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/policy/p...
File chrome/browser/policy/policy_browsertest.cc (left):

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/policy/p...
chrome/browser/policy/policy_browsertest.cc:3196: void HomepageIsNotNTP() {
On 2015/08/27 17:52:48, gab wrote:
> Seems we're removing an unintentionally supported policy use case (pinged on
> email thread to make sure this is okay -- no action required if they're okay
> with it).

I did some analysis and pinged the thread with my findings.

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/prefs/se...
File chrome/browser/prefs/session_startup_pref.h (left):

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/prefs/se...
chrome/browser/prefs/session_startup_pref.h:44: static const int
kPrefValueHomePage = 0;  // Deprecated
+asvitkine@chromium.org Your advice is needed is needed here. The comment above
reminds us to update histograms.xml. The value 0 is currently documented there
as:

<int value="0" label="Open home page (unused)"/>

Should we remove this entry as it is truly unused now, or should we leave it so
that if some old or misconfigured client does report a value of 0, we can easily
see in the histogram what this used to refer to?

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/prefs/se...
File chrome/browser/prefs/session_startup_pref_unittest.cc (right):

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/prefs/se...
chrome/browser/prefs/session_startup_pref_unittest.cc:21: bool
IsUseLastOpenDefault() {
Nit: This can be removed now.

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/prefs/se...
chrome/browser/prefs/session_startup_pref_unittest.cc:78:
TEST_F(SessionStartupPrefTest, DefaultMigration) {
Nit: This is obsolete now as well.

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/prefs/se...
chrome/browser/prefs/session_startup_pref_unittest.cc:102:
TEST_F(SessionStartupPrefTest, DefaultMigrationHomepageIsNTP) {
Nit: This is obsolete now as well.

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/sessions...
File chrome/browser/sessions/restore_on_startup_policy_handler.cc (left):

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/sessions...
chrome/browser/sessions/restore_on_startup_policy_handler.cc:90:
errors->AddError(policy_name(), IDS_POLICY_VALUE_DEPRECATED);
Please remove the string from components/policy_strings.grdp. It is not used
anywhere else.

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/sessions...
File chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc
(right):

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/sessions...
chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc:15:
#include "chrome/common/pref_names.h"
Nit: No longer used.

[sdefresne, 2015-09-02 11:30:19]

Thank you for the review, addressed all the comment.

I think the email thread was in favour of removing this, isn't it? If so, could
you take another view?

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/prefs/se...
File chrome/browser/prefs/session_startup_pref_unittest.cc (right):

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/prefs/se...
chrome/browser/prefs/session_startup_pref_unittest.cc:21: bool
IsUseLastOpenDefault() {
On 2015/08/31 at 15:36:43, bartfab wrote:
> Nit: This can be removed now.

Removed.

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/prefs/se...
chrome/browser/prefs/session_startup_pref_unittest.cc:78:
TEST_F(SessionStartupPrefTest, DefaultMigration) {
On 2015/08/31 at 15:36:43, bartfab wrote:
> Nit: This is obsolete now as well.

Removed.

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/prefs/se...
chrome/browser/prefs/session_startup_pref_unittest.cc:102:
TEST_F(SessionStartupPrefTest, DefaultMigrationHomepageIsNTP) {
On 2015/08/31 at 15:36:43, bartfab wrote:
> Nit: This is obsolete now as well.

Removed.

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/sessions...
File chrome/browser/sessions/restore_on_startup_policy_handler.cc (left):

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/sessions...
chrome/browser/sessions/restore_on_startup_policy_handler.cc:90:
errors->AddError(policy_name(), IDS_POLICY_VALUE_DEPRECATED);
On 2015/08/31 at 15:36:43, bartfab wrote:
> Please remove the string from components/policy_strings.grdp. It is not used
anywhere else.

Done.

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/sessions...
File chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc
(right):

https://codereview.chromium.org/1312693005/diff/20001/chrome/browser/sessions...
chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc:15:
#include "chrome/common/pref_names.h"
On 2015/08/31 at 15:36:43, bartfab wrote:
> Nit: No longer used.

Removed.

[bartfab (slow), 2015-09-03 09:34:37]

The code looks OK to me but the thread is still on-going. If we cannot be sure
how many enterprise users are actually still going through this path on a daily
basis, we should add more UMA stats to make an informed decision about removing
this value.

[sdefresne, 2015-09-03 09:57:48]

On 2015/09/03 at 09:34:37, bartfab wrote:
> The code looks OK to me but the thread is still on-going. If we cannot be sure
how many enterprise users are actually still going through this path on a daily
basis, we should add more UMA stats to make an informed decision about removing
this value.

Understood. I'll hold off until the question is resolved.
Thank you.

[gab, 2015-09-08 21:23:50]

One more thought on the code itself.

https://codereview.chromium.org/1312693005/diff/40001/chrome/browser/prefs/se...
File chrome/browser/prefs/session_startup_pref.cc (left):

https://codereview.chromium.org/1312693005/diff/40001/chrome/browser/prefs/se...
chrome/browser/prefs/session_startup_pref.cc:60:
registry->RegisterBooleanPref(prefs::kRestoreOnStartupMigrated, false);
Actually just thought of something more, we will need an inline cleanup path for
this pref before it's fully deleted, we typically do this in
browser_prefs.cc:MigrateObsoleteProfilePrefs().

I'd suggest removing the constant, moving it to a local declaration in that file
plus a ClearPref() call.

[Jason Robbins -- corp, 2015-10-09 18:52:39]

jrobbins@google.com changed reviewers:
+ asvitkine@chromium.org
- askvitkine@chromium.org

[Alexei Svitkine (slow), 2015-10-09 19:11:31]

lgtm

https://codereview.chromium.org/1312693005/diff/40001/chrome/browser/prefs/se...
File chrome/browser/prefs/session_startup_pref.cc (left):

https://codereview.chromium.org/1312693005/diff/40001/chrome/browser/prefs/se...
chrome/browser/prefs/session_startup_pref.cc:60:
registry->RegisterBooleanPref(prefs::kRestoreOnStartupMigrated, false);
On 2015/09/08 21:23:50, gab (very slow until Oct. 12) wrote:
> Actually just thought of something more, we will need an inline cleanup path
for
> this pref before it's fully deleted, we typically do this in
> browser_prefs.cc:MigrateObsoleteProfilePrefs().
> 
> I'd suggest removing the constant, moving it to a local declaration in that
file
> plus a ClearPref() call.

+1

https://codereview.chromium.org/1312693005/diff/40001/chrome/browser/prefs/se...
File chrome/browser/prefs/session_startup_pref.h (left):

https://codereview.chromium.org/1312693005/diff/40001/chrome/browser/prefs/se...
chrome/browser/prefs/session_startup_pref.h:37: TYPE_COUNT
Nit: This TYPE_COUNT made me thing this is used in an UMA histogram, but I
couldn't find the use of TYPE_COUNT in code search.

Given it's not used for UMA and this enum value isn't used in code, suggest
removing it while you're changing this.

[gab, 2015-11-12 13:43:45]

On 2015/09/03 09:34:37, bartfab (slow) wrote:
> The code looks OK to me but the thread is still on-going. If we cannot be sure
> how many enterprise users are actually still going through this path on a
daily
> basis, we should add more UMA stats to make an informed decision about
removing
> this value.

Is this resolved? I don't think UMA will help as enterprises typically don't
enable it.

[sdefresne, 2015-11-12 13:59:57]

On 2015/11/12 at 13:43:45, gab wrote:
> On 2015/09/03 09:34:37, bartfab (slow) wrote:
> > The code looks OK to me but the thread is still on-going. If we cannot be
sure
> > how many enterprise users are actually still going through this path on a
daily
> > basis, we should add more UMA stats to make an informed decision about
removing
> > this value.
> 
> Is this resolved? I don't think UMA will help as enterprises typically don't
enable it.

No decision was taken in the thread AFAIK.

[bartfab (slow), 2015-11-12 14:05:52]

On 2015/11/12 13:59:57, sdefresne wrote:
> On 2015/11/12 at 13:43:45, gab wrote:
> > On 2015/09/03 09:34:37, bartfab (slow) wrote:
> > > The code looks OK to me but the thread is still on-going. If we cannot be
> sure
> > > how many enterprise users are actually still going through this path on a
> daily
> > > basis, we should add more UMA stats to make an informed decision about
> removing
> > > this value.
> > 
> > Is this resolved? I don't think UMA will help as enterprises typically don't
> enable it.
> 
> No decision was taken in the thread AFAIK.

Correct. The thread seems to have stalled but nothing was decided. Feel free to
ping the thread.

[sdefresne, 2015-12-02 14:35:02]

Description was changed from

==========
Remove migration of obsolete value for "session.restore_on_startup".

Remove support of migration of kPrefValueHomePage (0) for the preference
"session.restore_on_startup" that was obsolete when M-19 was released.

Remove all usage of the constant kPrefValueHomePage and of the preference
"session.restore_on_startup_migrated" tracking whether the migration had
happened.

BUG=522526,522527
==========

to

==========
Remove migration of obsolete value for "session.restore_on_startup".

Remove support of migration of kPrefValueHomePage (0) for the preference
"session.restore_on_startup" that was obsolete when M-19 was released.

Remove all usage of the constant kPrefValueHomePage and of the preference
"session.restore_on_startup_migrated" tracking whether the migration had
happened.

BUG=525079
==========

[sdefresne, 2015-12-02 14:35:18]

gab: Please take another look!

https://codereview.chromium.org/1312693005/diff/40001/chrome/browser/prefs/se...
File chrome/browser/prefs/session_startup_pref.cc (left):

https://codereview.chromium.org/1312693005/diff/40001/chrome/browser/prefs/se...
chrome/browser/prefs/session_startup_pref.cc:60:
registry->RegisterBooleanPref(prefs::kRestoreOnStartupMigrated, false);
On 2015/10/09 at 19:11:31, Alexei Svitkine (slow) wrote:
> On 2015/09/08 21:23:50, gab (very slow until Oct. 12) wrote:
> > Actually just thought of something more, we will need an inline cleanup path
for
> > this pref before it's fully deleted, we typically do this in
> > browser_prefs.cc:MigrateObsoleteProfilePrefs().
> > 
> > I'd suggest removing the constant, moving it to a local declaration in that
file
> > plus a ClearPref() call.
> 
> +1

Done.

https://codereview.chromium.org/1312693005/diff/40001/chrome/browser/prefs/se...
File chrome/browser/prefs/session_startup_pref.h (left):

https://codereview.chromium.org/1312693005/diff/40001/chrome/browser/prefs/se...
chrome/browser/prefs/session_startup_pref.h:37: TYPE_COUNT
On 2015/10/09 at 19:11:31, Alexei Svitkine (slow) wrote:
> Nit: This TYPE_COUNT made me thing this is used in an UMA histogram, but I
couldn't find the use of TYPE_COUNT in code search.
> 
> Given it's not used for UMA and this enum value isn't used in code, suggest
removing it while you're changing this.

Done.

[gab, 2015-12-02 21:27:19]

lgtm w/ comments

Once again, amazed at how much code was supporting this long-unrequired
migration, glad you made a pass through it :-)!

PS: This CL makes me feel like kHomepageIsNewTabPage shouldn't be its own pref
(instead it should just be the default value of kHomepage), what do you think?
If you agree I'm happy to clean this up myself as a follow-up.

Thanks,
Gab

https://codereview.chromium.org/1312693005/diff/60001/chrome/browser/prefs/br...
File chrome/browser/prefs/browser_prefs.cc (right):

https://codereview.chromium.org/1312693005/diff/60001/chrome/browser/prefs/br...
chrome/browser/prefs/browser_prefs.cc:236: // Deprecated 12/2015.
This comment change belongs on your other CL I think.

https://codereview.chromium.org/1312693005/diff/60001/chrome/browser/sessions...
File chrome/browser/sessions/restore_on_startup_policy_handler.cc (right):

https://codereview.chromium.org/1312693005/diff/60001/chrome/browser/sessions...
chrome/browser/sessions/restore_on_startup_policy_handler.cc:35: 
I'd say no empty line needed here.

https://codereview.chromium.org/1312693005/diff/60001/components/policy_strin...
File components/policy_strings.grdp (right):

https://codereview.chromium.org/1312693005/diff/60001/components/policy_strin...
components/policy_strings.grdp:135: Value is out of range <ph
name="VALUE">$1<ex>10</ex></ph>.
Perhaps this should highlight the possibility of it being a deprecated value as
well?

Since this would now trigger instead of IDS_POLICY_VALUE_DEPRECATED for homepage
which is not "out of range" per se.

[sdefresne, 2015-12-03 10:28:33]

https://codereview.chromium.org/1312693005/diff/60001/chrome/browser/prefs/br...
File chrome/browser/prefs/browser_prefs.cc (right):

https://codereview.chromium.org/1312693005/diff/60001/chrome/browser/prefs/br...
chrome/browser/prefs/browser_prefs.cc:236: // Deprecated 12/2015.
On 2015/12/02 at 21:27:18, gab wrote:
> This comment change belongs on your other CL I think.

Ack, removed.

https://codereview.chromium.org/1312693005/diff/60001/chrome/browser/sessions...
File chrome/browser/sessions/restore_on_startup_policy_handler.cc (right):

https://codereview.chromium.org/1312693005/diff/60001/chrome/browser/sessions...
chrome/browser/sessions/restore_on_startup_policy_handler.cc:35: 
On 2015/12/02 at 21:27:18, gab wrote:
> I'd say no empty line needed here.

Done.

https://codereview.chromium.org/1312693005/diff/60001/components/policy_strin...
File components/policy_strings.grdp (right):

https://codereview.chromium.org/1312693005/diff/60001/components/policy_strin...
components/policy_strings.grdp:135: Value is out of range <ph
name="VALUE">$1<ex>10</ex></ph>.
On 2015/12/02 at 21:27:18, gab wrote:
> Perhaps this should highlight the possibility of it being a deprecated value
as well?
> 
> Since this would now trigger instead of IDS_POLICY_VALUE_DEPRECATED for
homepage which is not "out of range" per se.

Reverted the value IDS_POLICY_VALUE_DEPRECATED into existence instead.

[sdefresne, 2015-12-03 15:08:03]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2015-12-03 15:08:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, gab@chromium.org
Link to the patchset: https://codereview.chromium.org/1312693005/#ps80001
(title: "Address comments")

[commit-bot: I haz the power, 2015-12-03 15:08:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312693005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312693005/80001

[commit-bot: I haz the power, 2015-12-03 15:18:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 15:18:06]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sdefresne, 2015-12-03 15:21:51]

sdefresne@chromium.org changed reviewers:
+ sky@chromium.org

[sdefresne, 2015-12-03 15:21:52]

atwilson: please review the following as OWNERS
  chrome/browser/policy/policy_browsertest.cc
  chrome/browser/sessions/restore_on_startup_policy_handler.cc
  chrome/browser/sessions/restore_on_startup_policy_handler.h
  chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc

sky: please review the following as OWNERS
  chrome/browser/profile_resetter/profile_resetter.cc
  chrome/browser/ui/startup/startup_browser_creator_impl.cc

[gab, 2015-12-03 15:28:50]

Thanks, still lgtm, but a single nit on latest patch set.

https://codereview.chromium.org/1312693005/diff/80001/chrome/browser/sessions...
File chrome/browser/sessions/restore_on_startup_policy_handler.cc (right):

https://codereview.chromium.org/1312693005/diff/80001/chrome/browser/sessions...
chrome/browser/sessions/restore_on_startup_policy_handler.cc:51: case 0 /*
kPrefValueHomePage */:
case 0:  // Deprecated kPrefValueHomePage.

(i.e. specifically mention that the constant is deprecated and prefer // after :
to /* */

[sdefresne, 2015-12-03 15:34:13]

https://codereview.chromium.org/1312693005/diff/80001/chrome/browser/sessions...
File chrome/browser/sessions/restore_on_startup_policy_handler.cc (right):

https://codereview.chromium.org/1312693005/diff/80001/chrome/browser/sessions...
chrome/browser/sessions/restore_on_startup_policy_handler.cc:51: case 0 /*
kPrefValueHomePage */:
On 2015/12/03 at 15:28:49, gab wrote:
> case 0:  // Deprecated kPrefValueHomePage.
> 
> (i.e. specifically mention that the constant is deprecated and prefer // after
: to /* */

Done.

[sky, 2015-12-03 17:34:23]

LGTM

[sdefresne, 2015-12-07 10:19:59]

atwilson: ping?

[bartfab (slow), 2015-12-08 10:42:05]

lgtm

https://codereview.chromium.org/1312693005/diff/80001/chrome/common/pref_name...
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/1312693005/diff/80001/chrome/common/pref_name...
chrome/common/pref_names.cc:69: // 0: (deprecated) open the homepage on startup.
Nit: I think your earlier string ("unused, previously indicated to open the
homepage on startup") is still a better value here. "Deprecated" really means
"deprecated but still working" in Chrome. This value is truly gone.

[sdefresne, 2015-12-08 16:39:04]

atwilson: ping?

[Andrew T Wilson (Slow), 2015-12-08 18:09:35]

lgtm if you re-add the tests I talked to you about.

https://codereview.chromium.org/1312693005/diff/120001/chrome/browser/session...
File chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc
(left):

https://codereview.chromium.org/1312693005/diff/120001/chrome/browser/session...
chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc:92: new
base::FundamentalValue(SessionStartupPref::kPrefValueHomePage));
Let's restore this test.

https://codereview.chromium.org/1312693005/diff/120001/chrome/browser/session...
chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc:183: int
not_home_page = SessionStartupPref::kPrefValueHomePage + 1;
I think we should restore this test also as it's making sure that non-home-page
values are being unmigrated.

[sdefresne, 2015-12-09 18:39:25]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2015-12-09 18:39:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, gab@chromium.org, bartfab@chromium.org,
sky@chromium.org, atwilson@chromium.org
Link to the patchset: https://codereview.chromium.org/1312693005/#ps140001
(title: "Re-enable the two tests")

[sdefresne, 2015-12-09 18:41:06]

https://codereview.chromium.org/1312693005/diff/120001/chrome/browser/session...
File chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc
(left):

https://codereview.chromium.org/1312693005/diff/120001/chrome/browser/session...
chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc:92: new
base::FundamentalValue(SessionStartupPref::kPrefValueHomePage));
On 2015/12/08 at 18:09:34, Andrew T Wilson (Slow) wrote:
> Let's restore this test.

Done.

https://codereview.chromium.org/1312693005/diff/120001/chrome/browser/session...
chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc:183: int
not_home_page = SessionStartupPref::kPrefValueHomePage + 1;
On 2015/12/08 at 18:09:34, Andrew T Wilson (Slow) wrote:
> I think we should restore this test also as it's making sure that
non-home-page values are being unmigrated.

Done.

[commit-bot: I haz the power, 2015-12-09 18:42:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312693005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312693005/140001

[commit-bot: I haz the power, 2015-12-09 20:20:38]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-12-09 20:21:15]

Description was changed from

==========
Remove migration of obsolete value for "session.restore_on_startup".

Remove support of migration of kPrefValueHomePage (0) for the preference
"session.restore_on_startup" that was obsolete when M-19 was released.

Remove all usage of the constant kPrefValueHomePage and of the preference
"session.restore_on_startup_migrated" tracking whether the migration had
happened.

BUG=525079
==========

to

==========
Remove migration of obsolete value for "session.restore_on_startup".

Remove support of migration of kPrefValueHomePage (0) for the preference
"session.restore_on_startup" that was obsolete when M-19 was released.

Remove all usage of the constant kPrefValueHomePage and of the preference
"session.restore_on_startup_migrated" tracking whether the migration had
happened.

BUG=525079

Committed: https://crrev.com/245bbd424846eb696fea8b35718df3b7e9892c9f
Cr-Commit-Position: refs/heads/master@{#364142}
==========

[commit-bot: I haz the power, 2015-12-09 20:21:16]

Patchset 8 (id:??) landed as
https://crrev.com/245bbd424846eb696fea8b35718df3b7e9892c9f
Cr-Commit-Position: refs/heads/master@{#364142}