Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1312693004: Vector ICs: Ensure KeyedAccessStore mode is encoded in all handlers. (Closed)

Created:
5 years, 4 months ago by mvstanton
Modified:
5 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Vector ICs: Ensure KeyedAccessStore mode is encoded in all handlers. For vector-based keyed store ics, we need to know the current KeyedAccessStore mode on ic MISS, and to produce optimized code. We can't store this mode, which can change on any MISS in the IC without patching. Therefore, this CL makes sure that the information is redundantly available in the handlers embedded in the IC. This way, when --vector-stores is turned on, we'll be able to extract that information from the vector which maintains a list of these handlers. BUG= Committed: https://crrev.com/24921f76c60ea6e0c01866d121de7227ff095129 Cr-Commit-Position: refs/heads/master@{#30378}

Patch Set 1 #

Patch Set 2 : A few nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -30 lines) Patch
M src/ast.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/code-stubs.h View 1 7 chunks +30 lines, -20 lines 0 comments Download
M src/ic/ic.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +42 lines, -0 lines 0 comments Download
M src/ic/ic-compiler.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Yang, Here is the CL we discussed. Validates/protects that the handlers have the same ...
5 years, 4 months ago (2015-08-26 09:33:46 UTC) #2
Yang
On 2015/08/26 09:33:46, mvstanton wrote: > Hi Yang, > Here is the CL we discussed. ...
5 years, 3 months ago (2015-08-26 10:38:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312693004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312693004/20001
5 years, 3 months ago (2015-08-26 10:46:34 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-26 10:47:54 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 10:48:16 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24921f76c60ea6e0c01866d121de7227ff095129
Cr-Commit-Position: refs/heads/master@{#30378}

Powered by Google App Engine
This is Rietveld 408576698