extensions/common/extension_messages.h - Issue 1312653003: Fix for WebView accessible resources.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/common/extension_messages.h

Issue 1312653003: Fix for WebView accessible resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments by kalman@. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« extensions/browser/renderer_startup_helper.cc ('K') | « extensions/browser/renderer_startup_helper.cc ('k') | extensions/common/manifest_handlers/webview_info.h » ('j') | extensions/renderer/dispatcher.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // IPC messages for extensions.	5 // IPC messages for extensions.

6 // Multiply-included message file, hence no include guard.	6 // Multiply-included message file, hence no include guard.

7	7

8 #include <string>	8 #include <string>

9 #include <vector>	9 #include <vector>

10	10

(...skipping 784 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
795 int /* acc_obj_id */,	795 int /* acc_obj_id */,

796 base::string16 /* selector */)	796 base::string16 /* selector */)

797	797

798 // Result of a query selector request.	798 // Result of a query selector request.

799 // result_acc_obj_id is the accessibility tree ID of the result element; 0	799 // result_acc_obj_id is the accessibility tree ID of the result element; 0

800 // indicates no result.	800 // indicates no result.

801 IPC_MESSAGE_ROUTED3(ExtensionHostMsg_AutomationQuerySelector_Result,	801 IPC_MESSAGE_ROUTED3(ExtensionHostMsg_AutomationQuerySelector_Result,

802 int /* request_id */,	802 int /* request_id */,

803 ExtensionHostMsg_AutomationQuerySelector_Error /* error */,	803 ExtensionHostMsg_AutomationQuerySelector_Error /* error */,

804 int /* result_acc_obj_id */)	804 int /* result_acc_obj_id */)

	805

	806 // Report the WebView parition ID to the WebView guest renderer process.
	not at google - send to devlin 2015/08/31 18:31:44 You've added this to the "messages sent from rende You've added this to the "messages sent from renderer to browser" section, which isn't right. paulmeyer 2015/08/31 21:40:08 I've moved it to the correct section. I've also ma Show quoted text On 2015/08/31 18:31:44, kalman wrote: > You've added this to the "messages sent from renderer to browser" section, which > isn't right. I've moved it to the correct section. I've also made the comments about IPC direction more obvious, similar to: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/rend...
	807 IPC_MESSAGE_CONTROL1(ExtensionMsg_SetWebViewPartitionID,

	808 std::string /* webview_partition_id */)

OLD	NEW