Fix for WebView accessible resources.

extensions/common/manifest_handlers/webview_info.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_MANIFEST_HANDLERS_WEBVIEW_INFO_H_
 #define EXTENSIONS_COMMON_MANIFEST_HANDLERS_WEBVIEW_INFO_H_
 
 #include <string>
 
 #include "base/memory/scoped_vector.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/manifest_handler.h"
 
 namespace extensions {
 
 class PartitionItem;
 
 // A class to hold the <webview> accessible extension resources
 // that may be specified in the manifest of an extension using the
 // "webview" key.
 class WebviewInfo : public Extension::ManifestData {
  public:
+  // Get the WebviewInfo from |extension|'s manifest.
+  static const WebviewInfo* Get(const Extension* extension);
+
   // Define out of line constructor/destructor to please Clang.
   WebviewInfo(const std::string& extension_id);
   ~WebviewInfo() override;
 
   // Returns true if the specified resource is web accessible and the extension
   // matches the manifest's extension.
   bool IsResourceWebviewAccessible(const Extension* extension,

[not at google - send to devlin, 2015/09/03 20:17:54]

you know, it's actually silly that this isn't static and that callers can't just
do WebWebInfo::IsResourceWebviewAccessible(extension, ...) because needing to
grab the WebviewInfo object from an extension, then turning around and passing
it back in, is odd.

so I'd do that rather than adding a Get() method, after all that.

[paulmeyer, 2015/09/08 18:51:36]

I'll make it static, but I can keep the Get() function anyways and use it in the
static IsResourceWebviewAccessible() function.

[not at google - send to devlin, 2015/09/08 20:10:24]

If the only caller is IsResourceWebviewAccessible then there's no point having
Get. But if it isn't, then ok.

                                    const std::string& partition_id,
                                    const std::string& relative_path) const;
 
   void AddPartitionItem(scoped_ptr<PartitionItem> item);
 
  private:
   std::string extension_id_;
   ScopedVector<PartitionItem> partition_items_;
 };
 
 // Parses the "webview" manifest key.
 class WebviewHandler : public ManifestHandler {
  public:
   WebviewHandler();
   ~WebviewHandler() override;
 
   bool Parse(Extension* extension, base::string16* error) override;
 
  private:
   const std::vector<std::string> Keys() const override;
 
   DISALLOW_COPY_AND_ASSIGN(WebviewHandler);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_MANIFEST_HANDLERS_WEBVIEW_INFO_H_