Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1312643005: Reland of Make startCapture return synchronously to avoid Chrome no-responding on N9 with fast tab switching. (Closed)

Created:
5 years, 4 months ago by battre
Modified:
5 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Make startCapture return synchronously to avoid Chrome no-responding on N9 with fast tab switching. (patchset #1 id:1 of https://codereview.chromium.org/1316653002/ ) Reason for revert: Reverting did not help. Original issue's description: > Revert of Make startCapture return synchronously to avoid Chrome no-responding on N9 with fast tab switching. (patchset #5 id:80001 of https://codereview.chromium.org/1294953004/ ) > > Reason for revert: > Attempting a revert to see whether this fixes WebRtcGetUserMediaBrowserTest.RenderVideoTrackInMultipleTagsAndPause > > Original issue's description: > > On Nexus9, if you open two webrtc tabs and switch them very quickly, then chrome will stop responding soon. > > The reason is tab switching on Android will cause capture start/stop accordingly on the OnWasHidden/OnWasShown events. On N9 it's Camera2 API deployed. And with Camera2, capture will start asynchronously. If stopCapture comes too soon, it will fail and the next startCapture will cause the Camera2 into error status(You can't start capture twice in a row with Camera2 API) and freezes Chrome. > > > > This is a simple/straight patch to make the startCapture return synchronously. Please help to advice if this is proper here, or what other ideas you may have. > > > > BUG=501790 > > Test=Manual Test > > > > Committed: https://crrev.com/e4f0b8fffdaa39c929fde3dccd1561efbc7b6935 > > Cr-Commit-Position: refs/heads/master@{#345254} > > TBR=mcasas@chromium.org,magjed@chromium.org,braveyao@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=501790 > > Committed: https://crrev.com/db4af16e253cae77e6a56247e529b6c1cee6d55a > Cr-Commit-Position: refs/heads/master@{#345279} TBR=mcasas@chromium.org,magjed@chromium.org,braveyao@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=501790 Committed: https://crrev.com/e48147a249d94d55d8c907c7676573cd6af71cd0 Cr-Commit-Position: refs/heads/master@{#345289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -21 lines) Patch
M media/base/android/java/src/org/chromium/media/VideoCaptureCamera2.java View 10 chunks +40 lines, -21 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
battre
5 years, 4 months ago (2015-08-25 09:12:18 UTC) #1
Created Reland of Make startCapture return synchronously to avoid Chrome
no-responding on N9 with fast tab switching.

Powered by Google App Engine
This is Rietveld 408576698