content/renderer/render_frame_impl.cc - Issue 1312643002: Plumb opener information when creating RenderFrames and RenderFrameProxies for subframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1312643002: Plumb opener information when creating RenderFrames and RenderFrameProxies for subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@opener-CreateOpenerProxiesIfNeeded

Patch Set: Resolve conflict with Daniel's CL Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_impl.h ('K') | « content/renderer/render_frame_impl.h ('k') | content/renderer/render_frame_impl_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 908491004ff827d3d1b138023069eab7c9a1feab..c251a4589e97ccd2f96280c4c848a0fd5426df32 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -580,9 +580,10 @@ RenderFrameImpl* RenderFrameImpl::CreateMainFrame(RenderViewImpl* render_view,

// static

void RenderFrameImpl::CreateFrame(

int routing_id,

+ int proxy_routing_id,

+ int opener_routing_id,

int parent_routing_id,

int previous_sibling_routing_id,

- int proxy_routing_id,

const FrameReplicationState& replicated_state,

CompositorDependencies* compositor_deps,

const FrameMsg_NewFrame_WidgetParams& widget_params) {

@@ -624,6 +625,9 @@ void RenderFrameImpl::CreateFrame(

render_frame->SetWebFrame(web_frame);

CHECK_IMPLIES(parent_routing_id == MSG_ROUTING_NONE, !web_frame->parent());

+ WebFrame* opener = ResolveOpener(opener_routing_id, nullptr);

+ web_frame->setOpener(opener);

if (widget_params.routing_id != MSG_ROUTING_NONE) {

CHECK(SiteIsolationPolicy::AreCrossProcessFramesPossible());

render_frame->render_widget_ = RenderWidget::CreateForFrame(