Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: content/common/frame_messages.h

Issue 1312643002: Plumb opener information when creating RenderFrames and RenderFrameProxies for subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@opener-CreateOpenerProxiesIfNeeded
Patch Set: Add NewFrameProxy plumbing and test Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index 28f27db5245bbcb1507885ac71efa58a66915e4e..67c3393575c03eaa9bd075425615e9e9fa659e1d 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -337,6 +337,10 @@ IPC_STRUCT_BEGIN(FrameMsg_NewFrame_Params)
// configured to replace the proxy on commit.
IPC_STRUCT_MEMBER(int, proxy_routing_id)
+ // Specifies the new frame's opener. The opener will be null if this is
+ // MSG_ROUTING_NONE.
+ IPC_STRUCT_MEMBER(int, opener_routing_id)
+
// When the new frame has a parent, |replication_state| holds the new frame's
// properties replicated from the process rendering the parent frame, such as
// the new frame's sandbox flags.
@@ -455,10 +459,12 @@ IPC_MESSAGE_CONTROL1(FrameMsg_NewFrame, FrameMsg_NewFrame_Params /* params */)
// Instructs the renderer to create a new RenderFrameProxy object with
// |routing_id|. The new proxy should be created as a child of the object
// identified by |parent_routing_id| or as top level if that is
-// MSG_ROUTING_NONE.
-IPC_MESSAGE_CONTROL4(FrameMsg_NewFrameProxy,
+// MSG_ROUTING_NONE. The new proxy's opener should be set to the object
+// identified by |opener_routing_id|, or to null if that is MSG_ROUTING_NONE.
+IPC_MESSAGE_CONTROL5(FrameMsg_NewFrameProxy,
int /* routing_id */,
int /* parent_routing_id */,
+ int /* opener_routing_id */,
int /* render_view_routing_id */,
content::FrameReplicationState /* replication_state */)

Powered by Google App Engine
This is Rietveld 408576698