content/browser/frame_host/render_frame_proxy_host.cc - Issue 1312643002: Plumb opener information when creating RenderFrames and RenderFrameProxies for subframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_proxy_host.cc

Issue 1312643002: Plumb opener information when creating RenderFrames and RenderFrameProxies for subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@opener-CreateOpenerProxiesIfNeeded

Patch Set: Add NewFrameProxy plumbing and test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_impl.cc ('K') | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/browser/site_per_process_browsertest.cc » ('j') | content/browser/site_per_process_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_proxy_host.cc

diff --git a/content/browser/frame_host/render_frame_proxy_host.cc b/content/browser/frame_host/render_frame_proxy_host.cc

index e9e0edd05fad67c861f2f9571410424840a8f850..b91fd328fa21ac27e42f17d8275254cdde8db11c 100644

--- a/content/browser/frame_host/render_frame_proxy_host.cc

+++ b/content/browser/frame_host/render_frame_proxy_host.cc

@@ -185,8 +185,15 @@ bool RenderFrameProxyHost::InitRenderFrameProxy() {

CHECK_NE(parent_routing_id, MSG_ROUTING_NONE);

}

+ int opener_routing_id = MSG_ROUTING_NONE;

+ if (frame_tree_node_->opener()) {

+ opener_routing_id = frame_tree_node_->render_manager()->GetOpenerRoutingID(

+ site_instance_.get());

+ }

Send(new FrameMsg_NewFrameProxy(routing_id_,

parent_routing_id,

+ opener_routing_id,

frame_tree_node_->frame_tree()

->GetRenderViewHost(site_instance_.get())

->GetRoutingID(),