Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: content/renderer/render_frame_proxy.h

Issue 1312643002: Plumb opener information when creating RenderFrames and RenderFrameProxies for subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@opener-CreateOpenerProxiesIfNeeded
Patch Set: Fix param ordering in RenderThreadImpl::OnCreateNewFrameProxy Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl_browsertest.cc ('k') | content/renderer/render_frame_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_proxy.h
diff --git a/content/renderer/render_frame_proxy.h b/content/renderer/render_frame_proxy.h
index 2ab747ba2a616af10416c72444344a538d006303..6bcc907f55abd121b6b6673972fa470732302d64 100644
--- a/content/renderer/render_frame_proxy.h
+++ b/content/renderer/render_frame_proxy.h
@@ -74,18 +74,20 @@ class CONTENT_EXPORT RenderFrameProxy
// representation of a RenderFrame that has been created in another process --
// for example, after a cross-process navigation or after the addition of a
// new frame local to some other process. |routing_id| will be the ID of the
- // newly created RenderFrameProxy. |parent_routing_id| is the routing ID of
- // the RenderFrameProxy to which the new frame is parented.
- // |render_view_routing_id| identifies the RenderView to be associated with
- // this frame.
+ // newly created RenderFrameProxy. |render_view_routing_id| identifies the
+ // RenderView to be associated with this frame. |opener_routing_id|, if
+ // valid, is the routing ID of the new frame's opener. |parent_routing_id|
+ // is the routing ID of the RenderFrameProxy to which the new frame is
+ // parented.
//
// |parent_routing_id| always identifies a RenderFrameProxy (never a
// RenderFrame) because a new child of a local frame should always start out
// as a frame, not a proxy.
static RenderFrameProxy* CreateFrameProxy(
int routing_id,
- int parent_routing_id,
int render_view_routing_id,
+ int opener_routing_id,
+ int parent_routing_id,
const FrameReplicationState& replicated_state);
// Returns the RenderFrameProxy for the given routing ID.
« no previous file with comments | « content/renderer/render_frame_impl_browsertest.cc ('k') | content/renderer/render_frame_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698