Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1792)

Unified Diff: content/renderer/render_frame_impl.h

Issue 1312643002: Plumb opener information when creating RenderFrames and RenderFrameProxies for subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@opener-CreateOpenerProxiesIfNeeded
Patch Set: Fix param ordering in RenderThreadImpl::OnCreateNewFrameProxy Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/frame_messages.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 105d65a26e1b0ae517e01e14cc611f4f5ff5941e..7afa3518be22289b718b6ad663acab343244fee8 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -133,20 +133,23 @@ class CONTENT_EXPORT RenderFrameImpl
static RenderFrameImpl* CreateMainFrame(RenderViewImpl* render_view,
int32 routing_id);
- // Creates a new RenderFrame with |routing_id| as a child of the RenderFrame
- // identified by |parent_routing_id| or as the top-level frame if the latter
- // is MSG_ROUTING_NONE. If |proxy_routing_id| is MSG_ROUTING_NONE, it creates
- // the Blink WebLocalFrame and inserts it into the frame tree after the frame
- // identified by |previous_sibling_routing_id|, or as the first child if
+ // Creates a new RenderFrame with |routing_id|. If |proxy_routing_id| is
+ // MSG_ROUTING_NONE, it creates the Blink WebLocalFrame and inserts it into
+ // the frame tree after the frame identified by
+ // |previous_sibling_routing_id|, or as the first child if
// |previous_sibling_routing_id| is MSG_ROUTING_NONE. Otherwise, the frame is
// semi-orphaned until it commits, at which point it replaces the proxy
- // identified by |proxy_routing_id|. Note: This is called only when
+ // identified by |proxy_routing_id|. The frame's opener is set to the frame
+ // identified by |opener_routing_id|. The frame is created as a child of the
+ // RenderFrame identified by |parent_routing_id| or as the top-level frame if
+ // the latter is MSG_ROUTING_NONE. Note: This is called only when
// RenderFrame is being created in response to IPC message from the browser
// process. All other frame creation is driven through Blink and Create.
static void CreateFrame(int routing_id,
+ int proxy_routing_id,
+ int opener_routing_id,
int parent_routing_id,
int previous_sibling_routing_id,
- int proxy_routing_id,
const FrameReplicationState& replicated_state,
CompositorDependencies* compositor_deps,
const FrameMsg_NewFrame_WidgetParams& params);
« no previous file with comments | « content/common/frame_messages.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698