Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1249)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1312643002: Plumb opener information when creating RenderFrames and RenderFrameProxies for subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@opener-CreateOpenerProxiesIfNeeded
Patch Set: Fix param ordering in RenderThreadImpl::OnCreateNewFrameProxy Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/frame_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 722230a99199d0d627ebdec0efd75839e726b3f9..b40637ad97b8217b0e0fbf430cf8fdb1b0bde553 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -4395,16 +4395,17 @@ bool WebContentsImpl::CreateRenderViewForRenderManager(
bool WebContentsImpl::CreateRenderFrameForRenderManager(
RenderFrameHost* render_frame_host,
+ int proxy_routing_id,
+ int opener_routing_id,
int parent_routing_id,
- int previous_sibling_routing_id,
- int proxy_routing_id) {
+ int previous_sibling_routing_id) {
TRACE_EVENT0("browser,navigation",
"WebContentsImpl::CreateRenderFrameForRenderManager");
RenderFrameHostImpl* rfh =
static_cast<RenderFrameHostImpl*>(render_frame_host);
- if (!rfh->CreateRenderFrame(parent_routing_id, previous_sibling_routing_id,
- proxy_routing_id))
+ if (!rfh->CreateRenderFrame(proxy_routing_id, opener_routing_id,
+ parent_routing_id, previous_sibling_routing_id))
return false;
// TODO(nasko): When RenderWidgetHost is owned by RenderFrameHost, the passed
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/frame_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698