content/browser/frame_host/render_frame_host_manager.h - Issue 1312643002: Plumb opener information when creating RenderFrames and RenderFrameProxies for subframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 1312643002: Plumb opener information when creating RenderFrames and RenderFrameProxies for subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@opener-CreateOpenerProxiesIfNeeded

Patch Set: Fix param ordering in RenderThreadImpl::OnCreateNewFrameProxy Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/frame_host/render_frame_host_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager.h

diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h

index 9b36aaf1ac3c1b7b824544136501d8f03be1875a..c8542adac119a8938afa8fc189ca7fdf7ef43f1d 100644

--- a/content/browser/frame_host/render_frame_host_manager.h

+++ b/content/browser/frame_host/render_frame_host_manager.h

@@ -127,9 +127,10 @@ class CONTENT_EXPORT RenderFrameHostManager {

bool for_main_frame_navigation) = 0;

virtual bool CreateRenderFrameForRenderManager(

RenderFrameHost* render_frame_host,

+ int proxy_routing_id,

+ int opener_routing_id,

int parent_routing_id,

- int previous_sibling_routing_id,

- int proxy_routing_id) = 0;

+ int previous_sibling_routing_id) = 0;

virtual void BeforeUnloadFiredFromRenderManager(

bool proceed, const base::TimeTicks& proceed_time,

bool* proceed_to_fire_unload) = 0;

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/frame_host/render_frame_host_manager.cc » ('j') | no next file with comments »