content/renderer/render_frame_impl_browsertest.cc - Issue 1312643002: Plumb opener information when creating RenderFrames and RenderFrameProxies for subframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl_browsertest.cc

Issue 1312643002: Plumb opener information when creating RenderFrames and RenderFrameProxies for subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@opener-CreateOpenerProxiesIfNeeded

Patch Set: Rebase and fix arg order in CreateRenderFrame Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl_browsertest.cc

diff --git a/content/renderer/render_frame_impl_browsertest.cc b/content/renderer/render_frame_impl_browsertest.cc

index 4313b190a3ada31881e7e1b5d30df3b9555fde13..9646ba12778f1728f06aaf2557a19b5104bc1b54 100644

--- a/content/renderer/render_frame_impl_browsertest.cc

+++ b/content/renderer/render_frame_impl_browsertest.cc

@@ -50,10 +50,10 @@ class RenderFrameImplTest : public RenderViewTest {

view_->GetMainRenderFrame()->GetWebFrame()->firstChild())

->OnSwapOut(kFrameProxyRouteId, false, FrameReplicationState());

- RenderFrameImpl::CreateFrame(kSubframeRouteId, kFrameProxyRouteId,

- MSG_ROUTING_NONE, MSG_ROUTING_NONE,

- FrameReplicationState(), &compositor_deps_,

- widget_params);

+ RenderFrameImpl::CreateFrame(kSubframeRouteId, MSG_ROUTING_NONE,

+ MSG_ROUTING_NONE, kFrameProxyRouteId,

+ MSG_ROUTING_NONE, FrameReplicationState(),

+ &compositor_deps_, widget_params);

frame_ = RenderFrameImpl::FromRoutingID(kSubframeRouteId);

EXPECT_TRUE(frame_->is_subframe_);

« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_frame_proxy.h » ('j') | content/renderer/render_thread_impl.cc » ('J')