content/browser/web_contents/web_contents_impl.h - Issue 1312643002: Plumb opener information when creating RenderFrames and RenderFrameProxies for subframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 1312643002: Plumb opener information when creating RenderFrames and RenderFrameProxies for subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@opener-CreateOpenerProxiesIfNeeded

Patch Set: Rebase and fix arg order in CreateRenderFrame Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/site_per_process_browsertest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | content/renderer/render_thread_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 2bb8a45e855ac962e54fdcb6ffebeb3433446059..069888bec7d7a2def5b8036df4d2164b0184cc47 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -593,10 +593,12 @@ class CONTENT_EXPORT WebContentsImpl

int proxy_routing_id,

const FrameReplicationState& replicated_frame_state,

bool for_main_frame_navigation) override;

- bool CreateRenderFrameForRenderManager(RenderFrameHost* render_frame_host,

- int parent_routing_id,

- int previous_sibling_routing_id,

- int proxy_routing_id) override;

+ bool CreateRenderFrameForRenderManager(

+ RenderFrameHost* render_frame_host,

+ int proxy_routing_id,

+ int opener_routing_id,

+ int parent_routing_id,

+ int previous_sibling_routing_id) override;

void BeforeUnloadFiredFromRenderManager(

bool proceed,

const base::TimeTicks& proceed_time,