Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: content/renderer/render_frame_proxy.h

Issue 1312643002: Plumb opener information when creating RenderFrames and RenderFrameProxies for subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@opener-CreateOpenerProxiesIfNeeded
Patch Set: Fix param ordering in RenderThreadImpl::OnCreateNewFrameProxy Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_PROXY_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_PROXY_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_PROXY_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_PROXY_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 static RenderFrameProxy* CreateProxyToReplaceFrame( 67 static RenderFrameProxy* CreateProxyToReplaceFrame(
68 RenderFrameImpl* frame_to_replace, 68 RenderFrameImpl* frame_to_replace,
69 int routing_id, 69 int routing_id,
70 blink::WebTreeScopeType scope); 70 blink::WebTreeScopeType scope);
71 71
72 // This method should be used to create a RenderFrameProxy, when there isn't 72 // This method should be used to create a RenderFrameProxy, when there isn't
73 // an existing RenderFrame. It should be called to construct a local 73 // an existing RenderFrame. It should be called to construct a local
74 // representation of a RenderFrame that has been created in another process -- 74 // representation of a RenderFrame that has been created in another process --
75 // for example, after a cross-process navigation or after the addition of a 75 // for example, after a cross-process navigation or after the addition of a
76 // new frame local to some other process. |routing_id| will be the ID of the 76 // new frame local to some other process. |routing_id| will be the ID of the
77 // newly created RenderFrameProxy. |parent_routing_id| is the routing ID of 77 // newly created RenderFrameProxy. |render_view_routing_id| identifies the
78 // the RenderFrameProxy to which the new frame is parented. 78 // RenderView to be associated with this frame. |opener_routing_id|, if
79 // |render_view_routing_id| identifies the RenderView to be associated with 79 // valid, is the routing ID of the new frame's opener. |parent_routing_id|
80 // this frame. 80 // is the routing ID of the RenderFrameProxy to which the new frame is
81 // parented.
81 // 82 //
82 // |parent_routing_id| always identifies a RenderFrameProxy (never a 83 // |parent_routing_id| always identifies a RenderFrameProxy (never a
83 // RenderFrame) because a new child of a local frame should always start out 84 // RenderFrame) because a new child of a local frame should always start out
84 // as a frame, not a proxy. 85 // as a frame, not a proxy.
85 static RenderFrameProxy* CreateFrameProxy( 86 static RenderFrameProxy* CreateFrameProxy(
86 int routing_id, 87 int routing_id,
88 int render_view_routing_id,
89 int opener_routing_id,
87 int parent_routing_id, 90 int parent_routing_id,
88 int render_view_routing_id,
89 const FrameReplicationState& replicated_state); 91 const FrameReplicationState& replicated_state);
90 92
91 // Returns the RenderFrameProxy for the given routing ID. 93 // Returns the RenderFrameProxy for the given routing ID.
92 static RenderFrameProxy* FromRoutingID(int routing_id); 94 static RenderFrameProxy* FromRoutingID(int routing_id);
93 95
94 // Returns the RenderFrameProxy given a WebFrame. 96 // Returns the RenderFrameProxy given a WebFrame.
95 static RenderFrameProxy* FromWebFrame(blink::WebFrame* web_frame); 97 static RenderFrameProxy* FromWebFrame(blink::WebFrame* web_frame);
96 98
97 ~RenderFrameProxy() override; 99 ~RenderFrameProxy() override;
98 100
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 scoped_refptr<ChildFrameCompositingHelper> compositing_helper_; 174 scoped_refptr<ChildFrameCompositingHelper> compositing_helper_;
173 175
174 RenderViewImpl* render_view_; 176 RenderViewImpl* render_view_;
175 177
176 DISALLOW_COPY_AND_ASSIGN(RenderFrameProxy); 178 DISALLOW_COPY_AND_ASSIGN(RenderFrameProxy);
177 }; 179 };
178 180
179 } // namespace 181 } // namespace
180 182
181 #endif // CONTENT_RENDERER_RENDER_FRAME_PROXY_H_ 183 #endif // CONTENT_RENDERER_RENDER_FRAME_PROXY_H_
OLDNEW
« no previous file with comments | « content/renderer/render_frame_impl_browsertest.cc ('k') | content/renderer/render_frame_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698