LayoutTests/http/tests/notifications/click-document.html - Issue 1312623003: Flakyness: fix notifications/ tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/notifications/click-document.html

Issue 1312623003: Flakyness: fix notifications/ tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@webmidi-flakyness

Patch Set: rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/http/tests/notifications/click-document.html

diff --git a/LayoutTests/http/tests/notifications/click-document.html b/LayoutTests/http/tests/notifications/click-document.html

index 98341f6088884b2945523cd4a3882dcdb10939f5..d0aaf4b95574222759b6a01cd250f88eabad3708 100644

--- a/LayoutTests/http/tests/notifications/click-document.html

+++ b/LayoutTests/http/tests/notifications/click-document.html

@@ -5,15 +5,18 @@

+ <script src="../resources/permissions-helper.js"></script>

</head>

<body>

// Tests that Document-bound notifications will have their onclick event

// fired when they're being clicked on. When the test is being ran

// manually, grant Notification permission and click on the notification.

- if (window.testRunner)

- testRunner.setPermission('notifications', 'granted', location.origin, location.origin);

+ PermissionsHelper.setPermission('notifications', 'granted').then(function() {

+ var script = document.createElement('script');

+ script.src = 'resources/click-event-test.js';

+ document.body.appendChild(script);

+ });

</script>

- <script src="resources/click-event-test.js"></script>

</body>

</html>