Issue 1312613006: Add command-line parameter enabling assert messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1312613006: Add command-line parameter enabling assert messages. (Closed)

Created:
5 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
5 years, 3 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add command-line parameter enabling assert messages. Not passed through on every path yet.

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -13 lines)			Patch
M	pkg/compiler/lib/src/apiimpl.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/compiler.dart	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/dart2js.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/patch_parser.dart	View	3 chunks	+8 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/scanner/class_element_parser.dart	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/scanner/parser.dart	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/scanner/parser_task.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/scanner/partial_parser.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/scanner/scanner_task.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/parser_helper.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 3 (1 generated)

Lasse Reichstein Nielsen

5 years, 3 months ago (2015-09-02 12:39:04 UTC) #3

There is a Parser created in listener.dart#parse where I don't have direct
access to a compiler to get the flag value.