Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1312583009: Files.app: Reset hidden state of default commands when input elements are focused. (Closed)

Created:
5 years, 3 months ago by fukino
Modified:
5 years, 3 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Reset hidden state of default commands when input elements are focused. paste command's hidden property is set true when one directory is focused. However, it will not be reset when an input is focused just after on directory is focused, because different handler (forceDefaultHandler) handles canExecute event when inputs are focused. All cut/copy/paste/delete commands should be shown in input element, so this CL reset the hidden property of them. BUG=528843 TEST=manually tested on rename input, search input, and filename input on save-as dialog. Committed: https://crrev.com/b181a7749b8ec5eaa7aad6e42db9bdf0fc450bda Cr-Commit-Position: refs/heads/master@{#347870}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use early return. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
fukino
PTAL. Thanks!
5 years, 3 months ago (2015-09-09 06:33:03 UTC) #2
yawano
lgtm with nit. https://codereview.chromium.org/1312583009/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js File ui/file_manager/file_manager/foreground/js/file_manager_commands.js (right): https://codereview.chromium.org/1312583009/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js#newcode222 ui/file_manager/file_manager/foreground/js/file_manager_commands.js:222: if (event.command.id === commandId) { nit: ...
5 years, 3 months ago (2015-09-09 07:25:58 UTC) #3
fukino
Thank you! https://codereview.chromium.org/1312583009/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js File ui/file_manager/file_manager/foreground/js/file_manager_commands.js (right): https://codereview.chromium.org/1312583009/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js#newcode222 ui/file_manager/file_manager/foreground/js/file_manager_commands.js:222: if (event.command.id === commandId) { On 2015/09/09 ...
5 years, 3 months ago (2015-09-09 07:31:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312583009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312583009/20001
5 years, 3 months ago (2015-09-09 07:32:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-09 09:07:11 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 09:07:56 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b181a7749b8ec5eaa7aad6e42db9bdf0fc450bda
Cr-Commit-Position: refs/heads/master@{#347870}

Powered by Google App Engine
This is Rietveld 408576698