Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1312583006: Revert of Make separate net and url GN targets with and without ICU (Closed)

Created:
5 years, 3 months ago by xunjieli
Modified:
5 years, 3 months ago
Reviewers:
brettw, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make separate net and url GN targets with and without ICU (patchset #8 id:300001 of https://codereview.chromium.org/1287893005/ ) Reason for revert: This CL broke a GN check on an internal bot: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20GN/builds/29756 Running ['/b/build/slave/Android_GN/build/src/buildtools/linux64/gn', '--root=/b/build/slave/Android_GN/build/src', 'check', '//out/Release'] ERROR at //url/android/url_jni_registrar.cc:8:11: Include not allowed. #include "url/url_canon_icu_alternatives_android.h" ^--------------------------------------- It is not in any dependency of //url:url The include file is in the target(s): //url:url_lib_use_icu_alternatives_on_android which should somehow be reachable. Command ['/b/build/slave/Android_GN/build/src/buildtools/linux64/gn', '--root=/b/build/slave/Android_GN/build/src', 'check', '//out/Release'] returned exit code 1 Original issue's description: > Make separate net and url GN targets with and without ICU > > The net and url GYP files were modified in crrev.com/933293003 > so Cronet could be built side-by-side with Chrome. However GN > files are not modified. This CL keeps the GN files in sync > with the GYP files. > > BUG=522096 > > Committed: https://crrev.com/4c8c6921ca6739d16f6551635328faf164848f9d > Cr-Commit-Position: refs/heads/master@{#345891} TBR=mmenke@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=522096 Committed: https://crrev.com/06d9398786c3029299ce99e2da081c038859f534 Cr-Commit-Position: refs/heads/master@{#345906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+620 lines, -557 lines) Patch
M net/BUILD.gn View 12 chunks +440 lines, -389 lines 0 comments Download
M net/net.gypi View 6 chunks +82 lines, -88 lines 0 comments Download
M net/net_common.gypi View 2 chunks +26 lines, -7 lines 0 comments Download
M url/BUILD.gn View 3 chunks +64 lines, -73 lines 0 comments Download
A url/config.gni View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
xunjieli
Created Revert of Make separate net and url GN targets with and without ICU
5 years, 3 months ago (2015-08-27 17:11:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312583006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312583006/1
5 years, 3 months ago (2015-08-27 17:12:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 17:13:16 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 17:14:07 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06d9398786c3029299ce99e2da081c038859f534
Cr-Commit-Position: refs/heads/master@{#345906}

Powered by Google App Engine
This is Rietveld 408576698