Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1312563002: DevTools: [timeline tree view] fix total time calculation for recursive case. (Closed)

Created:
5 years, 4 months ago by alph
Modified:
5 years, 4 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: [timeline tree view] fix total time calculation for recursive case. BUG=523537 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201072

Patch Set 1 #

Patch Set 2 : minor tweaks #

Total comments: 2

Patch Set 3 : nodesStack -> nodesOnStack #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -25 lines) Patch
M LayoutTests/inspector/tracing/timeline-js-callstacks.html View 2 chunks +126 lines, -1 line 0 comments Download
M LayoutTests/inspector/tracing/timeline-js-callstacks-expected.txt View 4 chunks +40 lines, -18 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 1 2 2 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
alph
5 years, 4 months ago (2015-08-21 21:42:40 UTC) #2
yurys
lgtm https://codereview.chromium.org/1312563002/diff/20001/Source/devtools/front_end/timeline/TimelineModel.js File Source/devtools/front_end/timeline/TimelineModel.js (right): https://codereview.chromium.org/1312563002/diff/20001/Source/devtools/front_end/timeline/TimelineModel.js#newcode1555 Source/devtools/front_end/timeline/TimelineModel.js:1555: var nodesStack = /** @type {!Set<string>} */ (new ...
5 years, 4 months ago (2015-08-24 18:14:36 UTC) #3
alph
https://codereview.chromium.org/1312563002/diff/20001/Source/devtools/front_end/timeline/TimelineModel.js File Source/devtools/front_end/timeline/TimelineModel.js (right): https://codereview.chromium.org/1312563002/diff/20001/Source/devtools/front_end/timeline/TimelineModel.js#newcode1555 Source/devtools/front_end/timeline/TimelineModel.js:1555: var nodesStack = /** @type {!Set<string>} */ (new Set()); ...
5 years, 4 months ago (2015-08-24 18:19:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312563002/40001
5 years, 4 months ago (2015-08-24 18:19:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/59905)
5 years, 4 months ago (2015-08-24 19:04:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312563002/40001
5 years, 4 months ago (2015-08-24 20:14:50 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 20:19:21 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201072

Powered by Google App Engine
This is Rietveld 408576698