Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Unified Diff: Source/core/svg/SVGAnimatedType.cpp

Issue 131253002: [SVG] SVGAnimatedBoolean migration to new SVG property impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase/address comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGAnimatedType.cpp
diff --git a/Source/core/svg/SVGAnimatedType.cpp b/Source/core/svg/SVGAnimatedType.cpp
index cdaf271b1dcf2a75020d2b51553babb77f0f2e18..b453becfe77c92cf83575e4212c3549296999c7a 100644
--- a/Source/core/svg/SVGAnimatedType.cpp
+++ b/Source/core/svg/SVGAnimatedType.cpp
@@ -37,9 +37,6 @@ SVGAnimatedType::~SVGAnimatedType()
case AnimatedAngle:
delete m_data.angleAndEnumeration;
break;
- case AnimatedBoolean:
- delete m_data.boolean;
- break;
case AnimatedColor:
delete m_data.color;
break;
@@ -79,6 +76,8 @@ SVGAnimatedType::~SVGAnimatedType()
case AnimatedTransformList:
delete m_data.transformList;
break;
+ // Below properties are migrated to new property implementation.
+ case AnimatedBoolean:
case AnimatedLength:
case AnimatedLengthList:
// handled by RefPtr
@@ -97,14 +96,6 @@ PassOwnPtr<SVGAnimatedType> SVGAnimatedType::createAngleAndEnumeration(std::pair
return animatedType.release();
}
-PassOwnPtr<SVGAnimatedType> SVGAnimatedType::createBoolean(bool* boolean)
-{
- ASSERT(boolean);
- OwnPtr<SVGAnimatedType> animatedType = adoptPtr(new SVGAnimatedType(AnimatedBoolean));
- animatedType->m_data.boolean = boolean;
- return animatedType.release();
-}
-
PassOwnPtr<SVGAnimatedType> SVGAnimatedType::createColor(Color* color)
{
ASSERT(color);

Powered by Google App Engine
This is Rietveld 408576698