[SVG] SVGAnimatedBoolean migration to new SVG property impl.

Source/core/svg/SVGFEConvolveMatrixElement.h

 /*
  * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 52 matching lines @@
     }
 };
 
 class SVGFEConvolveMatrixElement FINAL : public SVGFilterPrimitiveStandardAttributes {
 public:
     static PassRefPtr<SVGFEConvolveMatrixElement> create(Document&);
 
     void setOrder(float orderX, float orderY);
     void setKernelUnitLength(float kernelUnitLengthX, float kernelUnitLengthY);
 
+    SVGAnimatedBoolean* preserveAlpha() const { return m_preserveAlpha.get(); }

[pdr., 2014/01/10 18:57:32]

Can we refptr-ize this return?

[haraken, 2014/01/14 03:32:47]

I don't have a strong opinion here, but as far as I see other code in Blink, we
return raw pointers from getters when it is clear that raw pointers are OK.

+
 private:
     explicit SVGFEConvolveMatrixElement(Document&);
 
     bool isSupportedAttribute(const QualifiedName&);
     virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERRIDE;
     virtual bool setFilterEffectAttribute(FilterEffect*, const QualifiedName&);
     virtual void svgAttributeChanged(const QualifiedName&);
     virtual PassRefPtr<FilterEffect> build(SVGFilterBuilder*, Filter*);
 
     static const AtomicString& orderXIdentifier();
     static const AtomicString& orderYIdentifier();
     static const AtomicString& kernelUnitLengthXIdentifier();
     static const AtomicString& kernelUnitLengthYIdentifier();
 
+    RefPtr<SVGAnimatedBoolean> m_preserveAlpha;
     BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGFEConvolveMatrixElement)
         DECLARE_ANIMATED_STRING(In1, in1)
         DECLARE_ANIMATED_INTEGER(OrderX, orderX)
         DECLARE_ANIMATED_INTEGER(OrderY, orderY)
         DECLARE_ANIMATED_NUMBER_LIST(KernelMatrix, kernelMatrix)
         DECLARE_ANIMATED_NUMBER(Divisor, divisor)
         DECLARE_ANIMATED_NUMBER(Bias, bias)
         DECLARE_ANIMATED_INTEGER(TargetX, targetX)
         DECLARE_ANIMATED_INTEGER(TargetY, targetY)
         DECLARE_ANIMATED_ENUMERATION(EdgeMode, edgeMode, EdgeModeType)
         DECLARE_ANIMATED_NUMBER(KernelUnitLengthX, kernelUnitLengthX)
         DECLARE_ANIMATED_NUMBER(KernelUnitLengthY, kernelUnitLengthY)
-        DECLARE_ANIMATED_BOOLEAN(PreserveAlpha, preserveAlpha)
     END_DECLARE_ANIMATED_PROPERTIES
 };
 
 } // namespace WebCore
 
 #endif