Issue 1312523002: DevTools: add range checks while adding console message to the SourceFrame

Issue 1312523002: DevTools: add range checks while adding console message to the SourceFrame (Closed)

Created:
5 years, 4 months ago by lushnikov

Modified:
5 years, 4 months ago

Reviewers:
pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: add range checks while adding console message to the SourceFrame As the liveEdit happens, we ideally need to update uiLocation of the error to the actual new script. However, this is a tedious task to do, so we would simply defend againt exceptions thrown in UI. R=pfeldman NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201047

Patch Set 1 #

Patch Set 2 : minus 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	Source/devtools/front_end/source_frame/SourceFrame.js	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download