Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1312513004: PPC: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. Port f4c079d450a5990639b295d40a3d1663d70412d6 Original commit message: There's no need to have one InstanceType per SIMD primitive type (this will not scale long-term). Also reduce the amount of code duplication and make it more robust wrt adding new SIMD types. R=bmeurer@chromium.org, jyan@ca.ibm.com, dstence@us.ibm.com, joransiu@ca.ibm.com BUG= Committed: https://crrev.com/a1733785cfd5f328fb8506e2768a89932c57c7da Cr-Commit-Position: refs/heads/master@{#30392}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -85 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 3 chunks +12 lines, -35 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 3 chunks +4 lines, -12 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 2 chunks +11 lines, -38 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
MTBrandyberry
5 years, 3 months ago (2015-08-26 18:55:08 UTC) #1
john.yan
lgtm
5 years, 3 months ago (2015-08-26 19:08:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312513004/1
5 years, 3 months ago (2015-08-26 19:10:14 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-08-26 19:10:21 UTC) #6
dstence
lgtm
5 years, 3 months ago (2015-08-26 19:22:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312513004/1
5 years, 3 months ago (2015-08-26 19:23:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 19:50:35 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 19:50:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1733785cfd5f328fb8506e2768a89932c57c7da
Cr-Commit-Position: refs/heads/master@{#30392}

Powered by Google App Engine
This is Rietveld 408576698