[heap] Enforce coding style decl order in {Heap} round #1.

[heap] Enforce coding style decl order in {Heap} round #1.

Order is now:
 - forward declarations
 - enums
 - nested classes
 - static consts
 - constructors
 - static methods
 - regular methods
 - members fields

Bonus:
 - Allocate*() methods are grouped together
 - Sections

BUG=

Committed: https://crrev.com/4095d606010988a014389cce1307c3de4e1edbff
Cr-Commit-Position: refs/heads/master@{#30327}

[Michael Lippautz, 2015-08-24 09:51:31]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Hannes Payer (out of office), 2015-08-24 10:38:39]

super awesome! can we add some comment sections c.f. compiler/code-generator.h ?

https://codereview.chromium.org/1312503004/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1312503004/diff/1/src/heap/heap.h#newcode1232
src/heap/heap.h:1232: #ifdef VERIFY_HEAP
Can we move these ifdefs to the end of the methods section?

[Michael Lippautz, 2015-08-24 11:14:27]

PTAL

There are some methods that are not in sections yet. Maybe move them later?

https://codereview.chromium.org/1312503004/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1312503004/diff/1/src/heap/heap.h#newcode1232
src/heap/heap.h:1232: #ifdef VERIFY_HEAP
On 2015/08/24 10:38:38, Hannes Payer wrote:
> Can we move these ifdefs to the end of the methods section?

Done.

[Hannes Payer (out of office), 2015-08-24 12:21:43]

LGTM, one nit

https://codereview.chromium.org/1312503004/diff/20001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):

https://codereview.chromium.org/1312503004/diff/20001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:475: PrintF("promoted=%" V8_PTR_PREFIX "d ",
heap_->PromotedObjectsSize());
These are true getters?

[Michael Lippautz, 2015-08-24 12:26:03]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2015-08-24 12:26:03]

The CQ bit was unchecked by mlippautz@chromium.org

[Michael Lippautz, 2015-08-24 12:26:03]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1312503004/#ps40001
(title: "Addressed comment and reverted back to regular static const double")

[Michael Lippautz, 2015-08-24 12:26:05]

The CQ bit was unchecked by mlippautz@chromium.org

[Michael Lippautz, 2015-08-24 12:26:05]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2015-08-24 12:26:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312503004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312503004/40001

[Michael Lippautz, 2015-08-24 12:29:59]

https://codereview.chromium.org/1312503004/diff/20001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):

https://codereview.chromium.org/1312503004/diff/20001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:475: PrintF("promoted=%" V8_PTR_PREFIX "d ",
heap_->PromotedObjectsSize());
On 2015/08/24 12:21:43, Hannes Payer wrote:
> These are true getters?

Yep, done.

[commit-bot: I haz the power, 2015-08-24 12:50:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-24 12:50:58]

Patchset 3 (id:??) landed as
https://crrev.com/4095d606010988a014389cce1307c3de4e1edbff
Cr-Commit-Position: refs/heads/master@{#30327}