Fix table cell background caching issue about interest rect

Source/core/paint/BlockPainter.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/paint/BlockPainter.h"
 
 #include "core/editing/DragCaretController.h"
 #include "core/editing/FrameSelection.h"
 #include "core/frame/Settings.h"
@@ skipping 11 matching lines @@
 #include "core/paint/ScopeRecorder.h"
 #include "core/paint/ScrollRecorder.h"
 #include "core/paint/ScrollableAreaPainter.h"
 #include "platform/graphics/paint/ClipRecorder.h"
 #include "wtf/Optional.h"
 
 namespace blink {
 
 void BlockPainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paintOffset)
 {
-    PaintInfo localPaintInfo(paintInfo);
+    if (!intersectsPaintRect(paintInfo, paintOffset))
+        return;
 
     LayoutPoint adjustedPaintOffset = paintOffset + m_layoutBlock.location();
-
+    PaintInfo localPaintInfo(paintInfo);
     PaintPhase originalPhase = localPaintInfo.phase;
 
-    // Check if we need to do anything at all.
-    LayoutRect overflowBox = overflowRectForPaintRejection();
-    m_layoutBlock.flipForWritingMode(overflowBox);
-    overflowBox.moveBy(adjustedPaintOffset);
-    if (!overflowBox.intersects(LayoutRect(localPaintInfo.rect)))
-        return;
-
     // There are some cases where not all clipped visual overflow is accounted for.
     // FIXME: reduce the number of such cases.
     ContentsClipBehavior contentsClipBehavior = ForceContentsClip;
     if (m_layoutBlock.hasOverflowClip() && !m_layoutBlock.hasControlClip() && !(m_layoutBlock.shouldPaintSelectionGaps() && originalPhase == PaintPhaseForeground) && !hasCaret())
         contentsClipBehavior = SkipContentsClipIfPossible;
 
     if (localPaintInfo.phase == PaintPhaseOutline) {
         localPaintInfo.phase = PaintPhaseChildOutlines;
     } else if (localPaintInfo.phase == PaintPhaseChildBlockBackground) {
         localPaintInfo.phase = PaintPhaseBlockBackground;
@@ skipping 178 matching lines @@
 
     FrameSelection& selection = frame->selection();
     if (hasCursorCaret(selection, &m_layoutBlock, frame))
         selection.paintCaret(paintInfo.context, paintOffset, LayoutRect(paintInfo.rect));
 
     DragCaretController& dragCaretController = frame->page()->dragCaretController();
     if (hasDragCaret(dragCaretController, &m_layoutBlock, frame))
         dragCaretController.paintDragCaret(frame, paintInfo.context, paintOffset, LayoutRect(paintInfo.rect));
 }
 
-LayoutRect BlockPainter::overflowRectForPaintRejection() const
+bool BlockPainter::intersectsPaintRect(const PaintInfo& paintInfo, const LayoutPoint& paintOffset) const
 {
     LayoutRect overflowRect = m_layoutBlock.visualOverflowRect();
-    if (!m_layoutBlock.hasOverflowModel() || !m_layoutBlock.usesCompositedScrolling())
-        return overflowRect;
-
-    overflowRect.unite(m_layoutBlock.layoutOverflowRect());
-    overflowRect.move(-m_layoutBlock.scrolledContentOffset());
-    return overflowRect;
+    if (m_layoutBlock.hasOverflowModel() && m_layoutBlock.usesCompositedScrolling()) {
+        overflowRect.unite(m_layoutBlock.layoutOverflowRect());
+        overflowRect.move(-m_layoutBlock.scrolledContentOffset());
+    }
+    m_layoutBlock.flipForWritingMode(overflowRect);
+    overflowRect.moveBy(paintOffset + m_layoutBlock.location());
+    return (overflowRect.intersects(LayoutRect(paintInfo.rect)));
 }
 
 bool BlockPainter::hasCaret() const
 {
     LocalFrame* frame = m_layoutBlock.frame();
     return hasCursorCaret(frame->selection(), &m_layoutBlock, frame)
         || hasDragCaret(frame->page()->dragCaretController(), &m_layoutBlock, frame);
 }
 
 void BlockPainter::paintContents(const PaintInfo& paintInfo, const LayoutPoint& paintOffset)
@@ skipping 15 matching lines @@
 
         // We don't paint our own background, but we do let the kids paint their backgrounds.
         PaintInfo paintInfoForChild(paintInfo);
         paintInfoForChild.phase = newPhase;
         paintInfoForChild.updatePaintingRootForChildren(&m_layoutBlock);
         m_layoutBlock.paintChildren(paintInfoForChild, paintOffset);
     }
 }
 
 } // namespace blink