Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1312473018: [turbofan] Greedy: live range grouping. (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Greedy: live range grouping. Grouping of live ranges that would be beneficial if allocated on the same register. Currently, that means phi outputs and inputs. Committed: https://crrev.com/8043a53a0732fabdd295c8d763b97d4333f51874 Cr-Commit-Position: refs/heads/master@{#30690}

Patch Set 1 : To-review #

Patch Set 2 : This is just perf #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -15 lines) Patch
M src/compiler/greedy-allocator.h View 6 chunks +43 lines, -6 lines 0 comments Download
M src/compiler/greedy-allocator.cc View 6 chunks +165 lines, -8 lines 0 comments Download
M src/compiler/register-allocator.h View 3 chunks +23 lines, -0 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Benedikt Meurer
LGTM (modulo the flag-definitions.h change of course). I think this is good to land, but ...
5 years, 3 months ago (2015-09-11 05:08:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312473018/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312473018/40001
5 years, 3 months ago (2015-09-11 05:10:35 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-11 05:35:49 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-11 05:36:01 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8043a53a0732fabdd295c8d763b97d4333f51874
Cr-Commit-Position: refs/heads/master@{#30690}

Powered by Google App Engine
This is Rietveld 408576698