Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1312473017: Introduce composed tree version of previousPositionOf() (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce composed tree version of previousPositionOf() This patch introduces composed tree version of |previousPositionOf()| by templatizing original |previousPositionOf()| to work both DOM tree position and composed tree position version for introducing composed tree version of |VisibleSelection| class. This patch also templatizes |skipToStartOfEditingBoundary()| used by |previousPositionOf()|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201963

Patch Set 1 : 2015-09-09T15:16:13 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -8 lines) Patch
M Source/core/editing/VisibleUnits.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 4 chunks +19 lines, -7 lines 0 comments Download
M Source/core/editing/VisibleUnitsTest.cpp View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-09 06:39:41 UTC) #2
yoichio
lgtm
5 years, 3 months ago (2015-09-09 07:00:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312473017/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312473017/1
5 years, 3 months ago (2015-09-09 07:09:55 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 09:45:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201963

Powered by Google App Engine
This is Rietveld 408576698