Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issue 1312473006: Fix Subzero's LLVM bitcode reader to use a diagnostic handler. (Closed)

Created:
5 years, 3 months ago by Karl
Modified:
5 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Subzero's LLVM bitcode reader to use a diagnostic handler. This encorporate the changes introduced by llvm CL https://codereview.chromium.org/1310883003 (see for details). BUG=None R=dschuff@chromium.org, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=25529f7bdaf3dfa08455b87642a120e84961d6d6

Patch Set 1 #

Patch Set 2 : Fix formatting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/IceCompiler.cpp View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Karl
5 years, 3 months ago (2015-08-24 22:33:11 UTC) #2
Derek Schuff
lgtm
5 years, 3 months ago (2015-08-24 22:46:55 UTC) #3
Jim Stichnoth
science-dog lgtm
5 years, 3 months ago (2015-08-24 23:19:22 UTC) #4
Karl
5 years, 3 months ago (2015-08-25 20:47:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
25529f7bdaf3dfa08455b87642a120e84961d6d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698