Compile remoting client plugin with GN

remoting/webapp/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Keep in sync with targets in remoting/remoting_client.gypi.
 
 import("//build/config/features.gni")
 import("//remoting/webapp/build_template.gni")
 import("//remoting/webapp/files.gni")
 
@@ skipping 14 matching lines @@
   args = [
     "credits",
     rebase_path(about_credits_file, root_build_dir),
     "--file-template",
     rebase_path("base/html/credits.tmpl", root_build_dir),
     "--entry-template",
     rebase_path("base/html/credits_entry.tmpl", root_build_dir),
   ]
 }
 
-desktop_remoting_webapp("webapp") {
-  webapp_type = "desktop"
-  output_dir = "$root_build_dir/remoting/remoting-webapp.v2"
-  zip_path = "$root_build_dir/remoting/remoting-webapp.v2.zip"
-  extra_files = [
-    "crd/remoting_client_pnacl.nmf.jinja2",
-    # TODO(garykac): Get correct path to this.
-    #"<(PRODUCT_DIR)/remoting_client_plugin_newlib.pexe",
+group("webapp") {

[garykac, 2015/08/31 23:27:10]

Why expand this out as part of this CL?  Previously all the CRD/AR code was in
build_template.gni, but this change splits where the HTML files are built.

[Sergey Ulanov, 2015/09/01 00:06:46]

This was the only place where the desktop_remoting_webapp() template was applied
and we will need to cleanup build_template.gni anyway, so I didn't see much
value in keeping the template. If you disagree I can add it back and add
client/plugin dependency in the template.

[garykac, 2015/09/01 20:53:27]

Even if we need to do this at some point, it doesn't seem like it belongs in
this cl. It clutters the diff and hides any changes that relate to what is in
the cl's description.

[Sergey Ulanov, 2015/09/03 00:07:14]

ok, returned the template back

+  locales_listfile_output = "$target_gen_dir/webapp_locales.txt"
+  build_locales_listfile("webapp_locales") {
+    # Template uses locales_listfile_output from outer scope.
+  }
+
+  background_html_output = "$target_gen_dir/html/webapp/background.html"
+
+  build_webapp_html("webapp_background_html") {
+    html_template_file = remoting_webapp_template_background
+    html_template_include_files = []
+    js_files = remoting_webapp_background_html_all_js_files
+    html_output = background_html_output
+  }
+
+  message_window_html_output = "$target_gen_dir/html/webapp/message_window.html"
+
+  build_webapp_html("webapp_message_window_html") {
+    html_template_file = remoting_webapp_template_message_window
+    html_template_include_files = []
+    js_files = remoting_webapp_message_window_html_all_js_files
+    html_output = message_window_html_output
+  }
+
+  wcs_sandbox_html_output = "$target_gen_dir/html/webapp/wcs_sandbox.html"
+
+  build_webapp_html("webapp_wcs_sandbox_html") {
+    html_template_file = remoting_webapp_template_wcs_sandbox
+    html_template_include_files = []
+    js_files = remoting_webapp_wcs_sandbox_html_all_js_files
+    html_output = wcs_sandbox_html_output
+  }
+
+  main_html_output = "$target_gen_dir/html/webapp/main.html"
+
+  build_webapp_html("webapp_main_html") {
+    html_template_file = remoting_webapp_template_main
+    html_template_include_files = remoting_webapp_template_files
+    js_files = remoting_webapp_crd_main_html_all_js_files
+    html_output = main_html_output
+  }
+
+  action("build_webapp") {
+    script = "//remoting/webapp/build-webapp.py"
+
+    zip_path = "$root_build_dir/remoting/remoting-webapp.v2.zip"
+
+    dr_generated_html_files = [
+      background_html_output,
+      message_window_html_output,
+      wcs_sandbox_html_output,
+      main_html_output,
+      "$target_gen_dir/credits.html",
+    ]
+
+    pexe_dir = get_label_info(
+            "//remoting/client/plugin:remoting_client_plugin_newlib(//native_client/build/toolchain/nacl:newlib_pnacl)",
+            "root_out_dir")
+    files_relative = [
+                       "crd/manifest.json.jinja2",
+                       "crd/remoting_client_pnacl.nmf.jinja2",
+                       "$pexe_dir/remoting_client_plugin_newlib.pexe",
+                     ] + dr_generated_html_files + remoting_webapp_crd_files
+    inputs = files_relative + remoting_version_files
+    files = rebase_path(files_relative, root_build_dir)
+
+    outputs = [
+      zip_path,
+    ]
+
+    deps = [
+      ":webapp_locales",
+      ":webapp_background_html",
+      ":webapp_message_window_html",
+      ":webapp_wcs_sandbox_html",
+      ":webapp_main_html",
+      "//remoting/resources",
+      "//remoting/webapp:credits",
+      "//remoting/client/plugin:remoting_client_plugin_newlib(//native_client/build/toolchain/nacl:newlib_pnacl)",
+    ]
+
+    # Create a file that contains a list of all the resource files needed
+    # to build the webapp. This is needed to avoid problems on platforms that
+    # limit the size of a command line.
+    file_list = "$target_gen_dir/${target_name}_files.txt"
+    write_file(file_list, files)
+
+    args = [
+      buildtype,
+      chrome_version_full,
+      rebase_path("$root_build_dir/remoting/remoting-webapp.v2",
+                  root_build_dir),
+      rebase_path(zip_path, root_build_dir),
+      rebase_path("crd/manifest.json.jinja2", root_build_dir),
+      "desktop",
+      "--files_listfile",
+      rebase_path(file_list, root_build_dir),
+      "--locales_listfile",
+      rebase_path(locales_listfile_output, root_build_dir),
+      "--use_gcd",
+      "$remoting_use_gcd",
+    ]
+  }
+
+  deps = [
+    ":build_webapp",
   ]
 }
 
 app_remoting_webapp("ar_sample_app") {
   app_key = "Sample_App"
   app_id = "ljacajndfccfgnfohlgkdphmbnpkjflk"
   app_client_id = "sample_client_id"
   app_vendor = ""
   app_name = "sample_app"
   app_fullname = "App Remoting Client"
@@ skipping 84 matching lines @@
       rebase_path(outputs, root_build_dir) + [
         rebase_path(remoting_webapp_unittests_template_main, root_build_dir),
         "--exclude-js",
       ] +
       rebase_path(remoting_webapp_unittests_exclude_js_files, root_build_dir) +
       [
         "--js-list-file",
         rebase_path(file_list, root_build_dir),
       ] + [ "--instrument-js" ] + rebase_path(webapp_js_files, root_build_dir)
 }