chrome/browser/push_messaging/push_messaging_service_impl.cc - Issue 1312453005: Removed Profile::GetHostContentSettingsMap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_service_impl.cc

Issue 1312453005: Removed Profile::GetHostContentSettingsMap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed Notification Subscription from SupervisedProvider Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/push_messaging/push_messaging_service_impl.cc

diff --git a/chrome/browser/push_messaging/push_messaging_service_impl.cc b/chrome/browser/push_messaging/push_messaging_service_impl.cc

index f5b7bcd2afce888f7c29414fc18cb29f30cf25a2..515d813a2ef6c14e807994b7d033a41e0111139d 100644

--- a/chrome/browser/push_messaging/push_messaging_service_impl.cc

+++ b/chrome/browser/push_messaging/push_messaging_service_impl.cc

@@ -745,7 +745,7 @@ void PushMessagingServiceImpl::SetContentSettingChangedCallbackForTesting(

void PushMessagingServiceImpl::Shutdown() {

GetGCMDriver()->RemoveAppHandler(kPushMessagingAppIdentifierPrefix);

- profile_->GetHostContentSettingsMap()->RemoveObserver(this);

+ HostContentSettingsMapFactory::GetForProfile(profile_)->RemoveObserver(this);

#if defined(ENABLE_BACKGROUND)

// TODO(mvanouwerkerk): Ensure Push API unregisters correctly from Background

// Mode - crbug.com/527036.